Skip to content
This repository was archived by the owner on Apr 16, 2026. It is now read-only.

Commit 4207cb4

Browse files
Upgrade to 0.17 (#262)
* A minimal upgrade * Correct the dependencies * Continue * Copy from @viridia (cart/bevy@ab73319) * Continue * target() -> event().event_target() * EventWriter/Reader -> MessageWriter/Reader & add_event -> add_message * Fix display issue * Pass all checks * I hope this work --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
1 parent a3dbcfd commit 4207cb4

61 files changed

Lines changed: 789 additions & 477 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Cargo.toml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,10 @@ unsafe_op_in_unsafe_fn = "warn"
2727
unused_qualifications = "warn"
2828

2929
[workspace.dependencies]
30-
bevy = { git = "https://github.com/cart/bevy.git", rev = "05b79c229a070224c007994e5c2be8b67439d7d9", features = [
31-
"wayland",
32-
"experimental_bevy_feathers",
33-
] }
34-
bevy_render = { git = "https://github.com/cart/bevy.git", rev = "05b79c229a070224c007994e5c2be8b67439d7d9" }
35-
bevy_derive = { git = "https://github.com/cart/bevy.git", rev = "05b79c229a070224c007994e5c2be8b67439d7d9" }
36-
bevy_macro_utils = { git = "https://github.com/cart/bevy.git", rev = "05b79c229a070224c007994e5c2be8b67439d7d9" }
37-
thiserror = "2.0"
30+
bevy = { git = "https://github.com/cart/bevy.git", rev = "87a21ecafa51bfaea02834b5933f08397b45b984", features = ["experimental_bevy_feathers"] }
31+
bevy_derive = { git = "https://github.com/cart/bevy.git", rev = "87a21ecafa51bfaea02834b5933f08397b45b984" }
32+
bevy_macro_utils = { git = "https://github.com/cart/bevy.git", rev = "87a21ecafa51bfaea02834b5933f08397b45b984" }
33+
thiserror = "2"
3834
serde = { version = "1", features = ["derive"] }
3935
tracing-test = "0.2.5"
4036
tracing = "0.1.41"

bevy_editor_panes/bevy_2d_viewport/src/lib.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
//! 2d Viewport for Bevy
22
use bevy::{
3+
camera::{RenderTarget, visibility::RenderLayers},
34
feathers::theme::ThemedText,
45
prelude::*,
5-
render::{
6-
camera::RenderTarget,
7-
render_resource::{Extent3d, TextureFormat, TextureUsages},
8-
view::RenderLayers,
9-
},
6+
render::render_resource::{Extent3d, TextureFormat, TextureUsages},
107
scene2::{CommandsSpawnScene, bsn, on},
118
ui::ui_layout_system,
129
};
@@ -50,7 +47,7 @@ impl Plugin for Viewport2dPanePlugin {
5047
query: Query<&Bevy2dViewport>| {
5148
// Despawn the viewport camera
5249
commands
53-
.entity(query.get(trigger.target()).unwrap().camera_id)
50+
.entity(query.get(trigger.event().event_target()).unwrap().camera_id)
5451
.despawn();
5552
},
5653
);

bevy_editor_panes/bevy_3d_viewport/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ bevy_editor_cam.workspace = true
1010
bevy_editor_styles.workspace = true
1111
bevy_infinite_grid.workspace = true
1212
bevy_editor_core.workspace = true
13-
bevy_render.workspace = true
1413
bevy_transform_gizmos.workspace = true
1514

1615
[lints]

bevy_editor_panes/bevy_3d_viewport/src/lib.rs

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
11
//! 3D Viewport for Bevy
22
use bevy::{
33
asset::uuid::Uuid,
4+
camera::{NormalizedRenderTarget, RenderTarget, visibility::RenderLayers},
45
feathers::theme::ThemedText,
56
picking::{
67
PickingSystems,
78
input::{mouse_pick_events, touch_pick_events},
89
pointer::{Location, PointerId, PointerInput},
910
},
1011
prelude::*,
11-
render::{
12-
camera::{NormalizedRenderTarget, RenderTarget},
13-
render_resource::{Extent3d, TextureFormat, TextureUsages},
14-
view::RenderLayers,
15-
},
12+
render::render_resource::{Extent3d, TextureFormat, TextureUsages},
1613
scene2::{CommandsSpawnScene, bsn, on},
1714
ui::ui_layout_system,
1815
};
@@ -74,7 +71,7 @@ impl Plugin for Viewport3dPanePlugin {
7471
query: Query<&Bevy3dViewport>| {
7572
// Despawn the viewport camera
7673
commands
77-
.entity(query.get(trigger.target()).unwrap().camera_id)
74+
.entity(query.get(trigger.event().event_target()).unwrap().camera_id)
7875
.despawn();
7976
},
8077
);
@@ -108,8 +105,8 @@ fn render_target_picking_passthrough(
108105
content: Query<&PaneContentNode>,
109106
children_query: Query<&Children>,
110107
node_query: Query<(&ComputedNode, &UiGlobalTransform, &ImageNode), With<Active>>,
111-
mut pointer_input_reader: EventReader<PointerInput>,
112-
// Using commands to output PointerInput events to avoid clashing with the EventReader
108+
mut pointer_input_reader: MessageReader<PointerInput>,
109+
// Using commands to output PointerInput events to avoid clashing with the MessageReader
113110
mut commands: Commands,
114111
) {
115112
for event in pointer_input_reader.read() {
@@ -140,7 +137,7 @@ fn render_target_picking_passthrough(
140137
pointer_id: pointer_id_from_entity(pane_root),
141138
};
142139

143-
commands.write_event(event_copy);
140+
commands.write_message(event_copy);
144141
}
145142
}
146143
}
@@ -196,10 +193,10 @@ fn on_pane_creation(
196193
ImageNode::new(image.clone())
197194
:fit_to_parent
198195
on(|trigger: On<Pointer<Over>>, mut commands: Commands| {
199-
commands.entity(trigger.target()).insert(Active);
196+
commands.entity(trigger.event().event_target()).insert(Active);
200197
})
201198
on(|trigger: On<Pointer<Out>>, mut commands: Commands| {
202-
commands.entity(trigger.target()).remove::<Active>();
199+
commands.entity(trigger.event().event_target()).remove::<Active>();
203200
})
204201
[ :view_gizmo_node ]
205202
],

bevy_editor_panes/bevy_3d_viewport/src/selection_box.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
use bevy::camera::primitives::Aabb;
12
use bevy::ecs::system::SystemParam;
23
use bevy::prelude::*;
34
use bevy_editor_core::selection::EditorSelection;
4-
use bevy_render::primitives::Aabb;
55

66
#[derive(SystemParam)]
77
pub struct SelectionBoxQueries<'w, 's> {

0 commit comments

Comments
 (0)