From 7741385cdf8da96e92621e873f1cabe4fe82e9f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mos=C3=A8=20Giordano?= <765740+giordano@users.noreply.github.com> Date: Sun, 22 Mar 2026 22:49:51 +0000 Subject: [PATCH 1/3] Require Node 24 --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 0651ab9e5..3b15a7c88 100644 --- a/action.yml +++ b/action.yml @@ -85,5 +85,5 @@ inputs: default: 'false' runs: - using: 'node20' + using: 'node24' main: 'dist/src/index.js' From 7774e58fb3a091552e885a3c420ac4edf7e5f090 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mos=C3=A8=20Giordano?= <765740+giordano@users.noreply.github.com> Date: Sun, 22 Mar 2026 22:59:07 +0000 Subject: [PATCH 2/3] Update CI jobs to use node24 --- .github/workflows/benchmarkjs.yml | 2 +- .github/workflows/ci-results-repo.yml | 24 +++++++++++------------ .github/workflows/ci.yml | 28 +++++++++++++-------------- .nvmrc | 2 +- 4 files changed, 28 insertions(+), 28 deletions(-) diff --git a/.github/workflows/benchmarkjs.yml b/.github/workflows/benchmarkjs.yml index 7c404ef58..acd0557d3 100644 --- a/.github/workflows/benchmarkjs.yml +++ b/.github/workflows/benchmarkjs.yml @@ -16,7 +16,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - name: Run benchmark run: cd examples/benchmarkjs && npm install && node bench.js | tee output.txt diff --git a/.github/workflows/ci-results-repo.yml b/.github/workflows/ci-results-repo.yml index 8e3dedf6f..5a936a9e8 100644 --- a/.github/workflows/ci-results-repo.yml +++ b/.github/workflows/ci-results-repo.yml @@ -18,7 +18,7 @@ jobs: dotnet-version: '6.0.101' # SDK Version to use. keep in line with examples/benchmarkdotnet/global.json - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -52,7 +52,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -86,7 +86,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -125,7 +125,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -164,7 +164,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -205,7 +205,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - uses: actions/setup-go@v4 with: @@ -242,7 +242,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - uses: actions/setup-java@v4 with: @@ -281,7 +281,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -324,7 +324,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - uses: actions/setup-python@v5 with: @@ -364,7 +364,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -399,7 +399,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -434,7 +434,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1ce553da8..b8933791c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - uses: actions/setup-dotnet@v3 with: @@ -50,7 +50,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -82,7 +82,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -119,7 +119,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -156,7 +156,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -195,7 +195,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - uses: actions/setup-go@v4 with: @@ -230,7 +230,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - uses: actions/setup-java@v4 with: @@ -269,7 +269,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -310,7 +310,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - uses: actions/setup-python@v5 with: @@ -348,7 +348,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -380,7 +380,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -412,7 +412,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run build @@ -445,7 +445,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run coverage @@ -464,7 +464,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: 'npm' - run: npm ci - run: npm run lint diff --git a/.nvmrc b/.nvmrc index 2edeafb09..cabf43b5d 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -20 \ No newline at end of file +24 \ No newline at end of file From ec7a924812feca1e0b8d7e652b070407f45cb234 Mon Sep 17 00:00:00 2001 From: Chris Trzesniewski Date: Thu, 26 Mar 2026 21:11:13 +0100 Subject: [PATCH 3/3] use nvmrc for ci jobs --- .github/workflows/benchmarkjs.yml | 2 +- .github/workflows/ci-results-repo.yml | 24 +++++++++++------------ .github/workflows/ci.yml | 28 +++++++++++++-------------- CHANGELOG.md | 1 + 4 files changed, 28 insertions(+), 27 deletions(-) diff --git a/.github/workflows/benchmarkjs.yml b/.github/workflows/benchmarkjs.yml index acd0557d3..943bbec8a 100644 --- a/.github/workflows/benchmarkjs.yml +++ b/.github/workflows/benchmarkjs.yml @@ -16,7 +16,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - name: Run benchmark run: cd examples/benchmarkjs && npm install && node bench.js | tee output.txt diff --git a/.github/workflows/ci-results-repo.yml b/.github/workflows/ci-results-repo.yml index 5a936a9e8..9adec16b0 100644 --- a/.github/workflows/ci-results-repo.yml +++ b/.github/workflows/ci-results-repo.yml @@ -18,7 +18,7 @@ jobs: dotnet-version: '6.0.101' # SDK Version to use. keep in line with examples/benchmarkdotnet/global.json - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -52,7 +52,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -86,7 +86,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -125,7 +125,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -164,7 +164,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -205,7 +205,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - uses: actions/setup-go@v4 with: @@ -242,7 +242,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - uses: actions/setup-java@v4 with: @@ -281,7 +281,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -324,7 +324,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - uses: actions/setup-python@v5 with: @@ -364,7 +364,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -399,7 +399,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -434,7 +434,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b8933791c..0ec0b4271 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - uses: actions/setup-dotnet@v3 with: @@ -50,7 +50,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -82,7 +82,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -119,7 +119,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -156,7 +156,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -195,7 +195,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - uses: actions/setup-go@v4 with: @@ -230,7 +230,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - uses: actions/setup-java@v4 with: @@ -269,7 +269,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -310,7 +310,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - uses: actions/setup-python@v5 with: @@ -348,7 +348,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -380,7 +380,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -412,7 +412,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run build @@ -445,7 +445,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run coverage @@ -464,7 +464,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 24 + node-version-file: '.nvmrc' cache: 'npm' - run: npm ci - run: npm run lint diff --git a/CHANGELOG.md b/CHANGELOG.md index fde549031..046b82ae5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,5 @@ ## Unreleased +- **chore** bump node to 24 (#339) # [v1.21.0](https://github.com/benchmark-action/github-action-benchmark/releases/tag/v1.21.0) - 02 Mar 2026