Move `rawTunes` to a separate data file

[estellecomment]

Problem : I am likely going to fork ror-player, and will change/delete/add the default tunes. For this I need to edit src/defaultTunes.ts, where there is a mix of data (rawTunes, a large object) and code (how to use this data to build the tunes). I don't want to edit code to do this.

Solution : Moving this rawTunes data to a json file in assets/. That way I can easily delete the original rawTunes and start over. (and probably .gitignore the file too)

[estellecomment]

If this is interesting for the project, I can contribute a PR, let me know !

[manumeter]

I think the biggest issue here is that code is used within the rawTunes definition. Especially, there are four important functions: repeat(), stretch(), crescendo() and decrescendo(). Although I have to say I would also prefer the patterns to be separate (maybe even one (yaml?) file per tune). But this would require quite some changes (even something like encoding at least these functions into the pattern string and then parse them in code).

If you want, I can show you how I solved the whole player customization thing for our samba reggae group in an okayish GitOps way by replacing/patching some of the upstream files.

[cdauth]

Personally it doesn’t seem to me like there is much of a difference editing a JSON file or a TypeScript file.

Apart from the functions used in the config that have already been mentioned, I think the biggest reason for using TypeScript is that the editor will typecheck the config and will give suggestions. Like this it is easier to spot errors in the tune config.

I do agree that it could be a good idea to split the tunes up into single files. I would prefer if those would be TypeScript files. A little challenge that I see with that compared to the current approach is that functions and types need to be imported separately in each file. Non-programmers could still start by copying an existing tune file and editing it when creating a new tune, but they would have a harder time using the functions because they would have to make sure to import them. Maybe we could avoid that by using something like import * as helpers.

Unfortunately I currently have very little time taking care of these issues. I hope my availability will improve again in a few months.

[estellecomment]

I made a PR which just moves the ts to a separate file.
I agree that having one file per tune would be nice. We could also group the tune with its .md description, rather than have separate directories.

I think this is a minimal change but already solves the problem ! We can make a separate PR for more tweaks later if needed.