Add tool elapsed timing, ✓/✗ result markers and polish TUI status/welcome rendering

Author: beacoder

python_agent_harness/agent.py

@@ -32,6 +32,7 @@
 from __future__ import annotations
 
 import json
+import time
 from typing import Any, Protocol
 
 from . import config
@@ -385,9 +386,11 @@ def _run_tools(self, calls: list[ToolCall], results: dict[str, str]) -> None:
             # status bar can show the active tool name beside the spinner.
             if self.top_level:
                 self.session.notify("tool_running", p.name)
+            start = time.monotonic()
             try:
                 result = self._execute_tool_call(p)
             except Exception as e:  # noqa: BLE001 - containment boundary
+                p.elapsed = time.monotonic() - start
                 results[p.id] = f"Error: tool {p.name!r} crashed during execution — {e}"
                 continue
             if isinstance(result, PendingToolResult):
@@ -397,12 +400,17 @@ def _run_tools(self, calls: list[ToolCall], results: dict[str, str]) -> None:
                 # executing in the meantime
                 async_calls.append((p, result))
             else:
+                p.elapsed = time.monotonic() - start
                 results[p.id] = sanitize_tool_result(result)
         for p, pending in async_calls:
+            start = time.monotonic()
             try:
-                results[p.id] = sanitize_tool_result(pending.wait())
+                result = pending.wait()
             except Exception as e:  # noqa: BLE001 - containment boundary
                 results[p.id] = f"Error: tool {p.name!r} crashed during execution — {e}"
+            else:
+                p.elapsed = time.monotonic() - start
+                results[p.id] = sanitize_tool_result(result)
 
     def _execute_pending(self) -> None:
         """TOOL state: run the round's pending tool calls.

python_agent_harness/models.py

@@ -22,6 +22,7 @@ class ToolCall:
     arguments: dict[str, Any] | str
     result: str | None = None
     diff: str | None = None  # unified diff for Edit/Write, for TUI rendering
+    elapsed: float | None = None  # execution wall-time in seconds (TUI display)
 
 
 @dataclass

python_agent_harness/tui.py

@@ -23,6 +23,7 @@
 from prompt_toolkit.history import FileHistory
 from prompt_toolkit.key_binding import KeyBindings
 from prompt_toolkit.patch_stdout import patch_stdout
+from rich import box
 from rich.console import Console, Group
 from rich.live import Live
 from rich.markdown import Markdown
@@ -630,30 +631,40 @@ def _build_history_rows(self, full: bool = False) -> list[Any]:
                         else:
                             params = ""
                         label = f"tool: {tc.name}({params})" if params else f"tool: {tc.name}"
-                        rows.append(Text(label, style="magenta"))
+                        rows.append(Text(f"▶ {label}", style="magenta"))
                 if body.strip():
                     rows.append(Markdown(f"**assistant:** {body}", style=ASSISTANT_STYLE))
             elif m.role == "tool":
                 preview = _tool_result_preview(m.text())
                 name = (m.name or "tool").lower()
-                rows.append(Text(f"{name} result:\n{preview}", style="dim"))
                 call = calls_by_id.get(m.tool_call_id)
+                # tool failures surface as "Error: ..." results (agent
+                # containment, missing args, MCP-reported errors)
+                failed = (m.text() or "").startswith("Error")
+                marker = "✗" if failed else "✓"
+                marker_style = "bold red" if failed else "green"
+                elapsed = ""
+                if call is not None and call.elapsed is not None:
+                    elapsed = f" ({call.elapsed:.1f}s)"
+                row = Text(style="dim")
+                row.append(f"{marker} {name} result{elapsed}:", style=marker_style)
+                row.append(f"\n{preview}")
+                rows.append(row)
                 if call is not None and call.diff:
                     rows.append(render_diff(call.diff))
         return rows
 
-    def _todos_panel(self) -> Panel | None:
-        """Todos panel — rebuilt every frame (not cached), so a
+    def _todos_panel(self) -> Group | None:
+        """Todos section — rebuilt every frame (not cached), so a
         TodoWrite call shows up immediately even mid-run."""
         if not self.session.todos:
             return None
-        title = "Todos"
         t = Table.grid(padding=(0, 1))
         for todo in self.session.todos[-8:]:
             status = todo.get("status", "")
             mark = {"completed": "✅", "in_progress": "⏳", "pending": "⬜"}.get(status, "•")
             t.add_row(mark, todo.get("content", ""))
-        return Panel(t, title=title, border_style="blue", expand=False)
+        return Group(Text("Todos", style="bold"), t)
 
     def _history_rows(self) -> list[Any]:
         """Cached history rows; rebuilt only when the conversation changes.
@@ -679,16 +690,19 @@ def _stream_row(self) -> Text | None:
         lines = max(3, cap - 3)
         preview = _tail_lines(stream, lines)
         preview = _tail_chars(preview, lines * max(1, width))
-        return Text(f"assistant: {preview}", style=ASSISTANT_STYLE)
+        row = Text(f"assistant: {preview}", style=ASSISTANT_STYLE)
+        # blinking block cursor, 2 Hz phase (same clock as the spinner)
+        if int(time.time() * 2) % 2 == 0:
+            row.append("▍")
+        return row
 
-    def _render_conversation(self) -> Panel:
+    def _render_conversation(self) -> Group | Text:
         rows = self._history_rows()
         stream_row = self._stream_row()
         if stream_row is not None:
             rows.append(stream_row)
         rows = self._apply_budget(rows)
-        group = Group(*rows) if rows else Text("(empty)")
-        return Panel(group, title="python-agent-harness", border_style="blue")
+        return Group(*rows) if rows else Text("(empty)")
 
     def _apply_budget(self, rows: list[Any]) -> list[Any]:
         """Keep the NEWEST rows that fit the visible terminal area.
@@ -741,11 +755,11 @@ def _visible_row_cap(self) -> int:
         height = getattr(self.console, "height", None)
         if not height or height <= 0:
             return 60
-        # reserve: status bar (1) + panel borders (2) + input prompt (1)
-        # + the pinned Todos panel when visible (its rows + 2 borders)
-        reserved = 4
+        # reserve: status bar (1) + input prompt (1)
+        # + the pinned Todos section when visible (its title line + rows)
+        reserved = 2
         if self.session.todos:
-            reserved += min(len(self.session.todos), 8) + 2
+            reserved += min(len(self.session.todos), 8) + 1
         return max(5, height - reserved)
 
     @staticmethod
@@ -777,48 +791,60 @@ def _render_frame(self) -> Group:
 
     def _status_bar(self) -> Text:
         mode = self.session.plan_mode.mode.value
-        mode_style = "yellow" if mode == "plan" else "green"
+        mode_style = "bold yellow" if mode == "plan" else "bold green"
         ratio = self.session.context_ratio
         ctx = ""
         if ratio is not None:
             pct = round(ratio * 100)
-            ctx = f" [Ctx:{pct}%/{round(config.CONTEXT_TRIGGER * 100)}%]"
+            trigger = round(config.CONTEXT_TRIGGER * 100)
+            filled = round(ratio * 10)
+            bar = "▓" * filled + "░" * (10 - filled)
+            ctx = f" [Ctx:{bar} {pct}%/{trigger}%]"
         t = Text()
         t.append(f" [{mode.upper()}]", style=mode_style)
-        t.append(ctx)
+        if ctx:
+            over = ratio is not None and ratio >= config.CONTEXT_TRIGGER
+            t.append(ctx, style="bold" if over else "")
         if getattr(self.session, "_save_error", None):
             t.append(" [!save]", style="red bold")
         if self.agent_running:
             frame = SPINNER_FRAMES[int(time.time() * 10) % len(SPINNER_FRAMES)]
             t.append(f" {frame}", style="bold cyan")
             if self._current_tool:
-                t.append(f" {self._current_tool}", style="cyan")
+                t.append(f" {self._current_tool}", style="bold cyan")
         elif self.question is not None:
             t.append(" ❓", style="yellow")
-        t.append(f"{self.status}", style="dim")
+        t.append(f"{self.status}", style=self._status_style())
         return t
 
+    def _status_style(self) -> str:
+        """Status-bar color by state: errors red, activity cyan, idle dim."""
+        s = self.status
+        if "error" in s or "failed" in s:
+            return "bold red"
+        if " ⏳" in s or " running" in s or "retrying" in s:
+            return "cyan"
+        return "dim"
+
     # ------------------------------------------------------------------
     # main loop
     # ------------------------------------------------------------------
     def run(self) -> None:
         self.console.print(
             Panel(
-                "python-agent-harness — agent execution harness\n"
-                "Commands: /plan /build /init /review /explain /compact "
-                "/save /summary /sessions /restore /help /exit\n"
-                "/init [project] [--extra TEXT]       create/update AGENTS.md\n"
-                "/review [project] [commit|branch|PR] review code changes\n"
-                "/explain [project] [target]          explain code\n"
-                "/sessions                            list saved sessions\n"
-                "/restore [path | title | --latest]   restore a saved session\n"
-                "Ctrl-C cancels the current execution (the app stays open); "
-                "Ctrl-D or /exit quits.\n"
-                "Type a message — Enter for a new line, Esc then Enter "
-                "(or Alt+Enter) to submit. Up/Down recall history.",
-                border_style="blue",
-            ),
-            markup=False,
+                Text.from_markup(
+                    "[bold]Commands:[/bold] /plan /build /init /review /explain "
+                    "/compact /save /summary /sessions /restore /help /exit\n\n"
+                    "Ctrl-C cancels the current execution (the app stays open); "
+                    "Ctrl-D or /exit quits.\n"
+                    "Type a message — Enter for a new line, Esc then Enter "
+                    "(or Alt+Enter) to submit. Up/Down recall history.\n\n"
+                    "[dim]Type [bold]/help[/bold] for the full command reference.[/dim]"
+                ),
+                title="[bold cyan]python-agent-harness — agent execution harness[/bold cyan]",
+                border_style="cyan",
+                box=box.ROUNDED,
+            )
         )
         if config.LLM_LOG_ENABLED:
             self.console.print(f"[dim]LLM logs: {self.session.client.log_path}[/dim]")

tests/test_tui.py

@@ -65,7 +65,10 @@ def test_frame_includes_status_bar(self):
         out = buf.getvalue()
         self.assertIn("hello agent", out)
         self.assertIn("[BUILD]", out)
-        self.assertIn("Ctx:55%", out)
+        self.assertIn("Ctx:", out)
+        self.assertIn("55%", out)  # context percentage
+        self.assertIn("▓", out)  # context mini progress bar
+        self.assertIn("░", out)
 
     def test_status_bar_pinned_on_top(self):
         """The status bar must come BEFORE the conversation panel so a