Skip to content

Commit f2699c4

Browse files
committed
Fix the Error Prone issues in the misc examples: unescape the HTML entities inside two {@code} javadoc tags so the angle brackets render literally rather than as </>, and make SamplingEntropySourceProvider's DevRandomChainedSource a static nested class since it never references its enclosing instance.
1 parent 54ca798 commit f2699c4

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

misc/src/main/java/org/bouncycastle/asn1/x500/examples/X500NameStyleExample.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* Background: RFC 5280 sec. A.1 (and X.520) define commonName as a
1717
* DirectoryString bounded by {@code ub-common-name = 64}, so the default
1818
* {@link BCStyle} rejects a longer CN at build time -
19-
* {@code new X500Name("CN=<80 chars>")} throws
19+
* {@code new X500Name("CN=<80 chars>")} throws
2020
* {@code IllegalArgumentException} from {@code BCStyle.encodeStringValue}
2121
* (github #750). Note this only affects <b>building</b> a name from its string
2222
* form; the DER parse path ({@code X500Name.getInstance(byte[])}) never routes

misc/src/main/java/org/bouncycastle/cades/examples/CAdESLongTermExample.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
* <p>This example uses a single CA-signed signer cert and a CRL from that
7070
* CA. {@link CAdESLongTermValuesUtil#applyLongTermValues(CMSSignedData,
7171
* org.bouncycastle.cms.SignerId, List, List, List, AlgorithmIdentifier,
72-
* DigestCalculatorProvider)} also accepts a {@code List&lt;BasicOCSPResp&gt;}
72+
* DigestCalculatorProvider)} also accepts a {@code List<BasicOCSPResp>}
7373
* for OCSP-based deployments; the assembly logic is identical.</p>
7474
*
7575
* <p>{@link CAdESLevelDetector} requires a signature time-stamp to be

misc/src/main/java/org/bouncycastle/jcajce/examples/SamplingEntropySourceProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public EntropySource get(int bitsRequired)
3232
return new DevRandomChainedSource(bitsRequired);
3333
}
3434

35-
private class DevRandomChainedSource
35+
private static class DevRandomChainedSource
3636
implements EntropySource
3737
{
3838
private static final int MAX_SAMPLES = 1000;

0 commit comments

Comments
 (0)