SOFIE-288 | apply code review suggestions

Author: anteeek

packages/live-status-gateway-api/api/components/piece/pieceStatus/abSessionAssignment-example.yaml

@@ -0,0 +1,3 @@
+poolName: 'VTR'
+sessionName: 'clip_intro'
+playerId: 1

packages/live-status-gateway-api/api/components/piece/pieceStatus/abSessionAssignment.yaml

@@ -0,0 +1,16 @@
+type: object
+title: AbSessionAssignment
+properties:
+  poolName:
+    description: The name of the AB Pool this session is for
+    type: string
+  sessionName:
+    description: Name of the session
+    type: string
+  playerId:
+    description: The assigned player ID
+    oneOf:
+      - type: string
+      - type: number
+required: [poolName, sessionName, playerId]
+additionalProperties: false

packages/live-status-gateway-api/api/components/piece/pieceStatus/pieceStatus-example.yaml

@@ -6,6 +6,4 @@ tags: ['camera']
 publicData:
   switcherSource: 1
 abSessions:
-  - poolName: 'VTR'
-    sessionName: 'clip_intro'
-    playerId: 1
+  - $ref: './abSessionAssignment-example.yaml'

packages/live-status-gateway-api/api/components/piece/pieceStatus/pieceStatus.yaml

@@ -1,21 +1,4 @@
 $defs:
-  abSessionAssignment:
-    type: object
-    title: AbSessionAssignment
-    properties:
-      poolName:
-        description: The name of the AB Pool this session is for
-        type: string
-      sessionName:
-        description: Name of the session
-        type: string
-      playerId:
-        description: The assigned player ID
-        oneOf:
-          - type: string
-          - type: number
-    required: [poolName, sessionName, playerId]
-    additionalProperties: false
   pieceStatus:
     type: object
     title: PieceStatus
@@ -43,7 +26,7 @@ $defs:
         description: AB playback session assignments for this Piece
         type: array
         items:
-          $ref: '#/$defs/abSessionAssignment'
+          $ref: './abSessionAssignment.yaml'
     required: [id, name, sourceLayer, outputLayer]
     additionalProperties: false
     examples:

packages/live-status-gateway/src/topics/activePlaylistTopic.ts

@@ -50,8 +50,6 @@ const PLAYLIST_KEYS = [
 	'timing',
 	'startedPlayback',
 	'quickLoop',
-	'assignedAbSessions',
-	'trackedAbSessions',
 ] as const
 type Playlist = PickKeys<DBRundownPlaylist, typeof PLAYLIST_KEYS>
 

packages/live-status-gateway/src/topics/helpers/pieceStatus.ts

@@ -1,7 +1,7 @@
 import { unprotectString } from '@sofie-automation/server-core-integration'
 import type { ShowStyleBaseExt } from '../../collections/showStyleBaseHandler.js'
 import type { PieceInstanceMin } from '../../collections/pieceInstancesHandler.js'
-import type { PieceStatus } from '@sofie-automation/live-status-gateway-api'
+import type { AbSessionAssignment, PieceStatus } from '@sofie-automation/live-status-gateway-api'
 import { clone } from '@sofie-automation/corelib/dist/lib'
 import type { DBRundownPlaylist } from '@sofie-automation/corelib/dist/dataModel/RundownPlaylist'
 import type { PickKeys } from '@sofie-automation/shared-lib/dist/lib/types'
@@ -33,7 +33,7 @@ function getAbSessions(pieceInstance: PieceInstanceMin, playlist?: PlaylistAbSes
 		return []
 	}
 
-	const abSessions = []
+	const abSessions: AbSessionAssignment[] = []
 
 	for (const session of pieceInstance.piece.abSessions) {
 		const trackedSession = playlist.trackedAbSessions.find(