feat(rpm): add RPM debuginfo support on Ubuntu

Author: rdesgroppes

.bazelci/tests.yml

@@ -29,16 +29,6 @@ default_tests: &default_tests
     - "//pkg/..."
     - "//tests/..."
     - "//toolchains/..."
-    - "-//tests/rpm/..."
-    - "-//pkg/legacy/tests/rpm/..."
-
-default_tests_with_rpm: &default_tests_with_rpm
-  test_targets:
-    - "//pkg/..."
-    - "//tests/..."
-    - "//toolchains/..."
-    # This has started to fail, even on CentOS.
-    - "-//tests/rpm:test_golden_debuginfo_rpm_contents"
 
 win_tests: &win_tests
   test_flags:
@@ -67,11 +57,14 @@ ubuntu2204: &ubuntu
   platform: ubuntu2204
   <<: *common
   <<: *default_tests
+  shell_commands:
+    - sudo apt-get update
+    - sudo apt-get install -y rpm elfutils # rpmbuild, eu-strip
 
 centos7: &centos
   platform: centos7_java11_devtoolset10
   <<: *common
-  <<: *default_tests_with_rpm
+  <<: *default_tests
 
 macos: &macos
   platform: macos

.bazelrc

@@ -1 +1,2 @@
 # Intentionally blank
+common --test_output=errors

pkg/rpm_pfg.bzl

@@ -604,6 +604,11 @@ def _pkg_rpm_impl(ctx):
     if ctx.attr.architecture:
         preamble_pieces.append("BuildArch: " + ctx.attr.architecture)
 
+    # Tune debuginfo package generation if requested
+    if ctx.attr.debuginfo:
+        preamble_pieces.append("%{{!?_enable_debug_packages:%debug_package}}")  # absent by default on Ubuntu
+        preamble_pieces.append("%undefine _unique_debug_names")  # set by default on Rocky, Ubuntu
+
     preamble_file = ctx.actions.declare_file(
         "{}.spec.preamble".format(rpm_name),
     )

toolchains/rpm/rpmbuild_configure.bzl

@@ -68,6 +68,8 @@ DEBUGINFO_TYPE_BY_OS_RELEASE = {
     "almalinux": DEBUGINFO_TYPE_CENTOS,
     "centos": DEBUGINFO_TYPE_CENTOS,
     "fedora": DEBUGINFO_TYPE_FEDORA,
+    "rocky": DEBUGINFO_TYPE_CENTOS,
+    "ubuntu": DEBUGINFO_TYPE_CENTOS,
 }
 
 DEBUGINFO_VALID_VALUES = [