Merge pull request #100 from basecamp/rz/close-sdk-gaps

Close all SDK coverage gaps with 25 new CLI commands

Author: robzolkos

SURFACE.txt

@@ -39,6 +39,7 @@ var accountShowCmd = &cobra.Command{
 		breadcrumbs := []Breadcrumb{
 			breadcrumb("boards", "fizzy board list", "List boards"),
 			breadcrumb("entropy", "fizzy account entropy --auto_postpone_period_in_days N", "Update auto-postpone period"),
+			breadcrumb("settings-update", "fizzy account settings-update --name \"name\"", "Update settings"),
 		}
 
 		printDetail(items, summary, breadcrumbs)
@@ -84,6 +85,176 @@ var accountEntropyCmd = &cobra.Command{
 	},
 }
 
+// Account settings update flags
+var accountSettingsUpdateName string
+
+var accountSettingsUpdateCmd = &cobra.Command{
+	Use:   "settings-update",
+	Short: "Update account settings",
+	Long:  "Updates account settings.",
+	RunE: func(cmd *cobra.Command, args []string) error {
+		if err := requireAuthAndAccount(); err != nil {
+			return err
+		}
+
+		if accountSettingsUpdateName == "" {
+			return newRequiredFlagError("name")
+		}
+
+		_, err := getSDK().Account().UpdateSettings(cmd.Context(), &generated.UpdateAccountSettingsRequest{
+			Name: accountSettingsUpdateName,
+		})
+		if err != nil {
+			return convertSDKError(err)
+		}
+
+		breadcrumbs := []Breadcrumb{
+			breadcrumb("show", "fizzy account show", "View account settings"),
+		}
+
+		printMutation(map[string]any{}, "", breadcrumbs)
+		return nil
+	},
+}
+
+var accountExportCreateCmd = &cobra.Command{
+	Use:   "export-create",
+	Short: "Create an account export",
+	Long:  "Creates a new account data export.",
+	RunE: func(cmd *cobra.Command, args []string) error {
+		if err := requireAuthAndAccount(); err != nil {
+			return err
+		}
+
+		data, _, err := getSDK().Account().CreateExport(cmd.Context())
+		if err != nil {
+			return convertSDKError(err)
+		}
+
+		items := normalizeAny(data)
+
+		exportID := ""
+		if export, ok := items.(map[string]any); ok {
+			if id, ok := export["id"]; ok {
+				exportID = fmt.Sprintf("%v", id)
+			}
+		}
+
+		var breadcrumbs []Breadcrumb
+		if exportID != "" {
+			breadcrumbs = []Breadcrumb{
+				breadcrumb("show", fmt.Sprintf("fizzy account export-show %s", exportID), "View export status"),
+			}
+		}
+
+		printMutation(items, "", breadcrumbs)
+		return nil
+	},
+}
+
+var accountExportShowCmd = &cobra.Command{
+	Use:   "export-show EXPORT_ID",
+	Short: "Show an account export",
+	Long:  "Shows the status of an account data export.",
+	Args:  cobra.ExactArgs(1),
+	RunE: func(cmd *cobra.Command, args []string) error {
+		if err := requireAuthAndAccount(); err != nil {
+			return err
+		}
+
+		data, _, err := getSDK().Account().GetExport(cmd.Context(), args[0])
+		if err != nil {
+			return convertSDKError(err)
+		}
+
+		breadcrumbs := []Breadcrumb{
+			breadcrumb("show", "fizzy account show", "View account settings"),
+		}
+
+		printDetail(normalizeAny(data), "", breadcrumbs)
+		return nil
+	},
+}
+
+var accountJoinCodeShowCmd = &cobra.Command{
+	Use:   "join-code-show",
+	Short: "Show the account join code",
+	Long:  "Shows the current join code for inviting new members.",
+	RunE: func(cmd *cobra.Command, args []string) error {
+		if err := requireAuthAndAccount(); err != nil {
+			return err
+		}
+
+		data, _, err := getSDK().Account().GetJoinCode(cmd.Context())
+		if err != nil {
+			return convertSDKError(err)
+		}
+
+		breadcrumbs := []Breadcrumb{
+			breadcrumb("reset", "fizzy account join-code-reset", "Reset join code"),
+			breadcrumb("show", "fizzy account show", "View account settings"),
+		}
+
+		printDetail(normalizeAny(data), "", breadcrumbs)
+		return nil
+	},
+}
+
+var accountJoinCodeResetCmd = &cobra.Command{
+	Use:   "join-code-reset",
+	Short: "Reset the account join code",
+	Long:  "Resets the join code, invalidating the previous one.",
+	RunE: func(cmd *cobra.Command, args []string) error {
+		if err := requireAuthAndAccount(); err != nil {
+			return err
+		}
+
+		_, err := getSDK().Account().ResetJoinCode(cmd.Context())
+		if err != nil {
+			return convertSDKError(err)
+		}
+
+		breadcrumbs := []Breadcrumb{
+			breadcrumb("show", "fizzy account join-code-show", "View new join code"),
+		}
+
+		printMutation(map[string]any{}, "", breadcrumbs)
+		return nil
+	},
+}
+
+// Account join code update flags
+var accountJoinCodeUpdateUsageLimit int
+
+var accountJoinCodeUpdateCmd = &cobra.Command{
+	Use:   "join-code-update",
+	Short: "Update the account join code",
+	Long:  "Updates the join code settings.",
+	RunE: func(cmd *cobra.Command, args []string) error {
+		if err := requireAuthAndAccount(); err != nil {
+			return err
+		}
+
+		if !cmd.Flags().Changed("usage-limit") {
+			return newRequiredFlagError("usage-limit")
+		}
+
+		_, err := getSDK().Account().UpdateJoinCode(cmd.Context(), &generated.UpdateJoinCodeRequest{
+			UsageLimit: int32(accountJoinCodeUpdateUsageLimit),
+		})
+		if err != nil {
+			return convertSDKError(err)
+		}
+
+		breadcrumbs := []Breadcrumb{
+			breadcrumb("show", "fizzy account join-code-show", "View join code"),
+		}
+
+		printMutation(map[string]any{}, "", breadcrumbs)
+		return nil
+	},
+}
+
 func init() {
 	rootCmd.AddCommand(accountCmd)
 
@@ -93,4 +264,18 @@ func init() {
 	// Entropy
 	accountEntropyCmd.Flags().IntVar(&accountEntropyAutoPostponePeriodInDays, "auto_postpone_period_in_days", 0, "Auto postpone period in days ("+validAutoPostponePeriodsHelp+")")
 	accountCmd.AddCommand(accountEntropyCmd)
+
+	// Settings update
+	accountSettingsUpdateCmd.Flags().StringVar(&accountSettingsUpdateName, "name", "", "Account name (required)")
+	accountCmd.AddCommand(accountSettingsUpdateCmd)
+
+	// Exports
+	accountCmd.AddCommand(accountExportCreateCmd)
+	accountCmd.AddCommand(accountExportShowCmd)
+
+	// Join code
+	accountCmd.AddCommand(accountJoinCodeShowCmd)
+	accountCmd.AddCommand(accountJoinCodeResetCmd)
+	accountJoinCodeUpdateCmd.Flags().IntVar(&accountJoinCodeUpdateUsageLimit, "usage-limit", 0, "Usage limit (required)")
+	accountCmd.AddCommand(accountJoinCodeUpdateCmd)
 }

internal/commands/account.go

@@ -138,3 +138,158 @@ func TestAccountEntropy(t *testing.T) {
 		assertExitCode(t, err, errors.ExitForbidden)
 	})
 }
+
+func TestAccountSettingsUpdate(t *testing.T) {
+	t.Run("updates account settings with name flag", func(t *testing.T) {
+		mock := NewMockClient()
+
+		SetTestModeWithSDK(mock)
+		SetTestConfig("token", "account", "https://api.example.com")
+		defer resetTest()
+
+		accountSettingsUpdateName = "New Name"
+		err := accountSettingsUpdateCmd.RunE(accountSettingsUpdateCmd, []string{})
+		accountSettingsUpdateName = ""
+
+		assertExitCode(t, err, 0)
+		if mock.PatchCalls[0].Path != "/account/settings.json" {
+			t.Errorf("expected path '/account/settings.json', got '%s'", mock.PatchCalls[0].Path)
+		}
+		body := mock.PatchCalls[0].Body.(map[string]any)
+		if body["name"] != "New Name" {
+			t.Errorf("expected name 'New Name', got '%v'", body["name"])
+		}
+	})
+
+	t.Run("requires name flag", func(t *testing.T) {
+		mock := NewMockClient()
+
+		SetTestModeWithSDK(mock)
+		SetTestConfig("token", "account", "https://api.example.com")
+		defer resetTest()
+
+		accountSettingsUpdateName = ""
+		err := accountSettingsUpdateCmd.RunE(accountSettingsUpdateCmd, []string{})
+
+		assertExitCode(t, err, errors.ExitInvalidArgs)
+	})
+}
+
+func TestAccountExportCreate(t *testing.T) {
+	t.Run("creates export", func(t *testing.T) {
+		mock := NewMockClient()
+		mock.PostResponse = &client.APIResponse{
+			StatusCode: 201,
+			Data:       map[string]any{"id": "export-1", "status": "pending"},
+		}
+
+		SetTestModeWithSDK(mock)
+		SetTestConfig("token", "account", "https://api.example.com")
+		defer resetTest()
+
+		err := accountExportCreateCmd.RunE(accountExportCreateCmd, []string{})
+		assertExitCode(t, err, 0)
+		if mock.PostCalls[0].Path != "/account/exports.json" {
+			t.Errorf("expected path '/account/exports.json', got '%s'", mock.PostCalls[0].Path)
+		}
+	})
+}
+
+func TestAccountExportShow(t *testing.T) {
+	t.Run("shows export by ID", func(t *testing.T) {
+		mock := NewMockClient()
+		mock.GetResponse = &client.APIResponse{
+			StatusCode: 200,
+			Data:       map[string]any{"id": "export-1", "status": "completed"},
+		}
+
+		SetTestModeWithSDK(mock)
+		SetTestConfig("token", "account", "https://api.example.com")
+		defer resetTest()
+
+		err := accountExportShowCmd.RunE(accountExportShowCmd, []string{"export-1"})
+		assertExitCode(t, err, 0)
+		if mock.GetCalls[0].Path != "/account/exports/export-1" {
+			t.Errorf("expected path '/account/exports/export-1', got '%s'", mock.GetCalls[0].Path)
+		}
+	})
+}
+
+func TestAccountJoinCodeShow(t *testing.T) {
+	t.Run("shows join code", func(t *testing.T) {
+		mock := NewMockClient()
+		mock.GetResponse = &client.APIResponse{
+			StatusCode: 200,
+			Data:       map[string]any{"code": "abc123", "usage_limit": float64(10)},
+		}
+
+		SetTestModeWithSDK(mock)
+		SetTestConfig("token", "account", "https://api.example.com")
+		defer resetTest()
+
+		err := accountJoinCodeShowCmd.RunE(accountJoinCodeShowCmd, []string{})
+		assertExitCode(t, err, 0)
+		if mock.GetCalls[0].Path != "/account/join_code.json" {
+			t.Errorf("expected path '/account/join_code.json', got '%s'", mock.GetCalls[0].Path)
+		}
+	})
+}
+
+func TestAccountJoinCodeReset(t *testing.T) {
+	t.Run("resets join code", func(t *testing.T) {
+		mock := NewMockClient()
+		mock.DeleteResponse = &client.APIResponse{
+			StatusCode: 204,
+			Data:       map[string]any{},
+		}
+
+		SetTestModeWithSDK(mock)
+		SetTestConfig("token", "account", "https://api.example.com")
+		defer resetTest()
+
+		err := accountJoinCodeResetCmd.RunE(accountJoinCodeResetCmd, []string{})
+		assertExitCode(t, err, 0)
+		if mock.DeleteCalls[0].Path != "/account/join_code.json" {
+			t.Errorf("expected path '/account/join_code.json', got '%s'", mock.DeleteCalls[0].Path)
+		}
+	})
+}
+
+func TestAccountJoinCodeUpdate(t *testing.T) {
+	t.Run("updates join code with usage-limit flag", func(t *testing.T) {
+		mock := NewMockClient()
+
+		SetTestModeWithSDK(mock)
+		SetTestConfig("token", "account", "https://api.example.com")
+		defer resetTest()
+
+		accountJoinCodeUpdateCmd.Flags().Set("usage-limit", "10")
+		defer func() {
+			accountJoinCodeUpdateUsageLimit = 0
+			accountJoinCodeUpdateCmd.Flags().Lookup("usage-limit").Changed = false
+		}()
+		err := accountJoinCodeUpdateCmd.RunE(accountJoinCodeUpdateCmd, []string{})
+
+		assertExitCode(t, err, 0)
+		if mock.PatchCalls[0].Path != "/account/join_code.json" {
+			t.Errorf("expected path '/account/join_code.json', got '%s'", mock.PatchCalls[0].Path)
+		}
+		body := mock.PatchCalls[0].Body.(map[string]any)
+		if body["usage_limit"] == nil {
+			t.Error("expected body to contain 'usage_limit'")
+		}
+	})
+
+	t.Run("requires usage-limit flag", func(t *testing.T) {
+		mock := NewMockClient()
+
+		SetTestModeWithSDK(mock)
+		SetTestConfig("token", "account", "https://api.example.com")
+		defer resetTest()
+
+		accountJoinCodeUpdateUsageLimit = 0
+		err := accountJoinCodeUpdateCmd.RunE(accountJoinCodeUpdateCmd, []string{})
+
+		assertExitCode(t, err, errors.ExitInvalidArgs)
+	})
+}