Address PR review feedback from cubic

- Use cmd.Flags().Changed() instead of == 0 for usage-limit flag detection
- Add length guards before accessing mock call slices in tests
- Add missing "rejects pseudo columns" sub-test for TestColumnMoveRight

Author: robzolkos

internal/commands/account.go

@@ -235,7 +235,7 @@ var accountJoinCodeUpdateCmd = &cobra.Command{
 			return err
 		}
 
-		if accountJoinCodeUpdateUsageLimit == 0 {
+		if !cmd.Flags().Changed("usage-limit") {
 			return newRequiredFlagError("usage-limit")
 		}
 

internal/commands/account_test.go

@@ -263,9 +263,12 @@ func TestAccountJoinCodeUpdate(t *testing.T) {
 		SetTestConfig("token", "account", "https://api.example.com")
 		defer resetTest()
 
-		accountJoinCodeUpdateUsageLimit = 10
+		accountJoinCodeUpdateCmd.Flags().Set("usage-limit", "10")
+		defer func() {
+			accountJoinCodeUpdateUsageLimit = 0
+			accountJoinCodeUpdateCmd.Flags().Lookup("usage-limit").Changed = false
+		}()
 		err := accountJoinCodeUpdateCmd.RunE(accountJoinCodeUpdateCmd, []string{})
-		accountJoinCodeUpdateUsageLimit = 0
 
 		assertExitCode(t, err, 0)
 		if mock.PatchCalls[0].Path != "/account/join_code.json" {

internal/commands/card_test.go

@@ -1070,6 +1070,9 @@ func TestCardPublish(t *testing.T) {
 		err := cardPublishCmd.RunE(cardPublishCmd, []string{"42"})
 		assertExitCode(t, err, 0)
 
+		if len(mock.PostCalls) != 1 {
+			t.Fatalf("expected 1 post call, got %d", len(mock.PostCalls))
+		}
 		if mock.PostCalls[0].Path != "/cards/42/publish.json" {
 			t.Errorf("expected path '/cards/42/publish.json', got '%s'", mock.PostCalls[0].Path)
 		}
@@ -1086,6 +1089,9 @@ func TestCardMarkRead(t *testing.T) {
 		err := cardMarkReadCmd.RunE(cardMarkReadCmd, []string{"42"})
 		assertExitCode(t, err, 0)
 
+		if len(mock.PostCalls) != 1 {
+			t.Fatalf("expected 1 post call, got %d", len(mock.PostCalls))
+		}
 		if mock.PostCalls[0].Path != "/cards/42/reading.json" {
 			t.Errorf("expected path '/cards/42/reading.json', got '%s'", mock.PostCalls[0].Path)
 		}
@@ -1102,6 +1108,9 @@ func TestCardMarkUnread(t *testing.T) {
 		err := cardMarkUnreadCmd.RunE(cardMarkUnreadCmd, []string{"42"})
 		assertExitCode(t, err, 0)
 
+		if len(mock.DeleteCalls) != 1 {
+			t.Fatalf("expected 1 delete call, got %d", len(mock.DeleteCalls))
+		}
 		if mock.DeleteCalls[0].Path != "/cards/42/reading.json" {
 			t.Errorf("expected path '/cards/42/reading.json', got '%s'", mock.DeleteCalls[0].Path)
 		}

internal/commands/column_test.go

@@ -373,4 +373,14 @@ func TestColumnMoveRight(t *testing.T) {
 			t.Errorf("expected path '/columns/col-1/right_position.json', got '%s'", mock.PostCalls[0].Path)
 		}
 	})
+
+	t.Run("rejects pseudo columns", func(t *testing.T) {
+		mock := NewMockClient()
+		SetTestModeWithSDK(mock)
+		SetTestConfig("token", "account", "https://api.example.com")
+		defer resetTest()
+
+		err := columnMoveRightCmd.RunE(columnMoveRightCmd, []string{"not-now"})
+		assertExitCode(t, err, errors.ExitInvalidArgs)
+	})
 }