Skip to content

Commit 7f2e38f

Browse files
zekraken-botzekraken-bot
authored
Merge pull request #679 from balancer/review/issue-678
Review: Rate Provider from Issue #678
2 parents 24ce7ca + e4724e9 commit 7f2e38f

4 files changed

Lines changed: 134 additions & 0 deletions

File tree

‎erc4626/WrappedNeverlandsMONErc4626VaultReviewda69.md‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
2+
# Rate Provider: WrappedNeverland sMON rate provider
3+
4+
## Details
5+
This report was autogenerated on 02/03/2026.
6+
7+
- Deployed at:
8+
- [Monad:0x08139339dd9A480CEB84D9C7CcE48BE436dB20b3](https://monadvision.com/address/0x08139339dd9A480CEB84D9C7CcE48BE436dB20b3)
9+
- Audit report(s):
10+
- [Audits](https://github.com/Neverland-Money/security-audits)
11+
12+
## Context
13+
The ERC4626 Rate Provider tracks the embedded yield within the vault.
14+
15+
## Review Checklist: Bare Minimum Compatibility
16+
Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use.
17+
18+
- [x] Tests based on the [balancer-v3-monorepo](https://github.com/balancer/balancer-v3-monorepo/tree/main/pkg/vault/test/foundry/fork) pass for the given ERC4626 vaults, which can be found [here](https://github.com/balancer/balancer-v3-erc4626-tests/tree/main/test).
19+
- [x] The required Vault implements the required operational ERC4626 Interface
20+
21+
### Administrative Privileges
22+
- [ ] The ERC4626 Vault is upgradeable** (e.g., via a proxy architecture).
23+
- [x] Other contracts which are part of the `mint` callchain are upgradeable**. You can find more information
24+
about the involved contracts in this [tenderly simulation](https://www.tdly.co/shared/simulation/0405f788-0aae-4120-9751-f701c72b9a32)
25+
26+
## Conclusion
27+
**Summary judgment: USABLE**
28+
Passing fork tests can be found at balancer/balancer-v3-erc4626-tests#111.
29+
30+
** upgradeable in this context means that:
31+
- The contract is a proxy contract with an implementation sourced from Etherscan.
32+

‎erc4626/registry.json‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2695,6 +2695,26 @@
26952695
"useUnderlyingForAddRemove": true,
26962696
"useWrappedForAddRemove": true
26972697
},
2698+
"0x08139339dd9A480CEB84D9C7CcE48BE436dB20b3": {
2699+
"asset": "0xA3227C5969757783154C60bF0bC1944180ed81B9",
2700+
"name": "WrappedNeverlandsMONErc4626Vault.md",
2701+
"summary": "safe",
2702+
"review": "./WrappedNeverlandsMONErc4626VaultReviewda69.md",
2703+
"warnings": [],
2704+
"upgradeableComponents": [
2705+
{
2706+
"entrypoint": "0x08139339dd9a480ceb84d9c7cce48be436db20b3",
2707+
"implementationReviewed": "0xf20a545013b74f7ed0239399217b130e4177e085"
2708+
},
2709+
{
2710+
"entrypoint": "0x80f00661b13cc5f6ccd3885be7b4c9c67545d585",
2711+
"implementationReviewed": "0xe3b56aad3c21531055f39e73a51e8ff29daad049"
2712+
}
2713+
],
2714+
"canUseBufferForSwaps": true,
2715+
"useUnderlyingForAddRemove": true,
2716+
"useWrappedForAddRemove": true
2717+
},
26982718
"0x5e073494678fB7FA4a05bB17d45941Dd9Dc469c1": {
26992719
"asset": "0x1B68626dCa36c7fE922fD2d55E4f631d962dE19c",
27002720
"name": "WrappedNeverlandshMONErc4626Vault.md",

‎rate-providers/WrappedNeverlandsMONRateProviderReview2f66.md‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
2+
# Rate Provider: WrappedNeverland sMON rate provider
3+
4+
## Details
5+
This report was autogenerated on 02/03/2026.
6+
7+
- Deployed at:
8+
- [Monad:0x9f80b425Fe4A6A31Da5f5fCDd285d951244D1ea1](https://monadvision.com/address/0x9f80b425Fe4A6A31Da5f5fCDd285d951244D1ea1)
9+
- Audit report(s):
10+
- [Audits](https://github.com/Neverland-Money/security-audits)
11+
12+
## Context
13+
Neverland is built on the Aave V3 architecture: a battle-tested,highly secure lending protocol.
14+
15+
## Review Checklist: Bare Minimum Compatibility
16+
Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use.
17+
18+
- [x] Implements the [`IRateProvider`](https://github.com/balancer/balancer-v2-monorepo/blob/bc3b3fee6e13e01d2efe610ed8118fdb74dfc1f2/pkg/interfaces/contracts/pool-utils/IRateProvider.sol) interface.
19+
- [x] `getRate` returns an 18-decimal fixed point number (i.e., 1 == 1e18) regardless of underlying token decimals.
20+
21+
### Administrative Privileges
22+
- [ ] The Rate Provider is upgradeable** (e.g., via a proxy architecture).
23+
- [x] Other contracts which are part of the `getRate` callchain are upgradeable**. You can find more information
24+
about the involved contracts in this [tenderly simulation](https://www.tdly.co/shared/simulation/3cc2c382-a539-4b9f-87f4-3fc56afd9bd8)
25+
26+
## Conclusion
27+
**Summary judgment: USABLE**
28+
29+
** upgradeable in this context means that:
30+
- The contract is a proxy contract with an implementation sourced from Etherscan and the proxy emitted an "Upgraded" event.
31+

‎rate-providers/registry.json‎

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6658,6 +6658,40 @@
66586658
}
66596659
]
66606660
},
6661+
"0x9f80b425Fe4A6A31Da5f5fCDd285d951244D1ea1": {
6662+
"asset": "0x08139339dd9A480CEB84D9C7CcE48BE436dB20b3",
6663+
"name": "WrappedNeverlandsMONRateProvider.md",
6664+
"summary": "safe",
6665+
"review": "./WrappedNeverlandsMONRateProviderReview2f66.md",
6666+
"warnings": [],
6667+
"factory": "",
6668+
"upgradeableComponents": [
6669+
{
6670+
"entrypoint": "0x08139339dd9a480ceb84d9c7cce48be436db20b3",
6671+
"implementationReviewed": "0xf20a545013b74f7ed0239399217b130e4177e085"
6672+
},
6673+
{
6674+
"entrypoint": "0x80f00661b13cc5f6ccd3885be7b4c9c67545d585",
6675+
"implementationReviewed": "0xe3b56aad3c21531055f39e73a51e8ff29daad049"
6676+
},
6677+
{
6678+
"entrypoint": "0xe77456457619ad1948336fbabc3883cb965b50d1",
6679+
"implementationReviewed": "0xb12c4bdf99c4ed3b78137b921a0eae382e710ddc"
6680+
},
6681+
{
6682+
"entrypoint": "0x22d47686b3aec9068768f84efd8ce2637a347b0a",
6683+
"implementationReviewed": "0xf6de0bbe3b277a7c1d56139e4084e917aaaa74d2"
6684+
},
6685+
{
6686+
"entrypoint": "0x368ee51e47a594fe1e9908b48228748a30bc7ca4",
6687+
"implementationReviewed": "0xe4bfe4071d363e1d4274fb8f79cb510b75913020"
6688+
},
6689+
{
6690+
"entrypoint": "0x98dc6e90d4c2f212ed9d124ad2afba4833268633",
6691+
"implementationReviewed": "0xe94c9f9a1893f23be38a5c0394e46ac05e8a5f8c"
6692+
}
6693+
]
6694+
},
66616695
"0x3b13D015D5249dE0614bB783193508E93520F140": {
66626696
"asset": "0x5e073494678fB7FA4a05bB17d45941Dd9Dc469c1",
66636697
"name": "WrappedNeverlandshMONRateProvider.md",
@@ -6667,12 +6701,29 @@
66676701
"factory": "",
66686702
"upgradeableComponents": [
66696703
{
6704+
"entrypoint": "0x08139339dd9a480ceb84d9c7cce48be436db20b3",
66706705
"entrypoint": "0x5e073494678fb7fa4a05bb17d45941dd9dc469c1",
66716706
"implementationReviewed": "0xf20a545013b74f7ed0239399217b130e4177e085"
66726707
},
66736708
{
66746709
"entrypoint": "0x80f00661b13cc5f6ccd3885be7b4c9c67545d585",
66756710
"implementationReviewed": "0xe3b56aad3c21531055f39e73a51e8ff29daad049"
6711+
},
6712+
{
6713+
"entrypoint": "0xe77456457619ad1948336fbabc3883cb965b50d1",
6714+
"implementationReviewed": "0xb12c4bdf99c4ed3b78137b921a0eae382e710ddc"
6715+
},
6716+
{
6717+
"entrypoint": "0x22d47686b3aec9068768f84efd8ce2637a347b0a",
6718+
"implementationReviewed": "0xf6de0bbe3b277a7c1d56139e4084e917aaaa74d2"
6719+
},
6720+
{
6721+
"entrypoint": "0x368ee51e47a594fe1e9908b48228748a30bc7ca4",
6722+
"implementationReviewed": "0xe4bfe4071d363e1d4274fb8f79cb510b75913020"
6723+
},
6724+
{
6725+
"entrypoint": "0x98dc6e90d4c2f212ed9d124ad2afba4833268633",
6726+
"implementationReviewed": "0xe94c9f9a1893f23be38a5c0394e46ac05e8a5f8c"
66766727
}
66776728
]
66786729
}

0 commit comments

Comments
 (0)