feat: option to disable config reload (#522)

* scan event time fields for non-zero fields. we sometimes have timestamp 0001-01-01

* group imports

* option to disable config reload since it causes memory issues on clusters with a high number of configmaps

Author: m-terra

controllers/config/config_controller.go

@@ -157,6 +157,7 @@ func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
 	namespace := os.Getenv(cnst.EnvPodNamespace)
 	cmName := os.Getenv(cnst.EnvConfigMapName)
 	podName := os.Getenv(cnst.EnvPodName)
+	configReload := os.Getenv(cnst.EnvConfigReload)
 
 	if err := r.setupEventLoggerImage(types.NamespacedName{
 		Namespace: namespace,
@@ -172,12 +173,16 @@ func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
 		return err
 	}
 
-	return ctrl.NewControllerManagedBy(mgr).
-		For(&corev1.ConfigMap{}).WithEventFilter(filter.NamePredicate{
-		Namespace: namespace,
-		Names:     []string{cmName},
-	},
-	).Complete(r)
+	if configReload == "true" {
+		return ctrl.NewControllerManagedBy(mgr).
+			For(&corev1.ConfigMap{}).WithEventFilter(filter.NamePredicate{
+			Namespace: namespace,
+			Names:     []string{cmName},
+		},
+		).Complete(r)
+	}
+
+	return nil
 }
 
 type Cfg struct {

controllers/logging/event_controller.go

@@ -25,6 +25,7 @@ import (
 	"github.com/go-logr/logr"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -160,6 +161,14 @@ func (p *loggingPredicate) logEvent(e runtime.Object) bool {
 	if p.Config.filter.Match(evt) {
 		var eventLogger logr.Logger
 		if len(p.Config.logFields) == 0 {
+			ts := evt.LastTimestamp
+			if ts.IsZero() {
+				ts = evt.FirstTimestamp
+			}
+			if ts.IsZero() {
+				ts = metav1.Time{Time: evt.EventTime.Time}
+			}
+
 			eventLogger = eventLog.WithValues(
 				"namespace", evt.Namespace,
 				"name", evt.Name,

helm/README.md

@@ -24,6 +24,7 @@ helm install my-k8s-event-logger-operator bakito/k8s-event-logger-operator --ver
 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
 | affinity | object | `{}` | Assign custom [affinity] rules to the deployment |
+| eventLogger.configReload | bool | `true` | Watch the configmap for changes. |
 | eventLogger.leaderElection | bool | `true` | Enable leader election for the controller |
 | eventLogger.leaderElectionResourceLock | string | `nil` | Leader election lock type |
 | eventLogger.resources | object | `{"limits":{"cpu":"200m","memory":"256Mi"},"requests":{"cpu":"100m","memory":"64Mi"}}` | Resource limits and requests for the logger pods. |

helm/templates/deployment.yaml

@@ -53,6 +53,8 @@ spec:
                   fieldPath: metadata.namespace
             - name: 'CONFIG_MAP_NAME'
               value: '{{ include "k8s-event-logger-operator.fullname" . }}'
+            - name: 'CONFIG_RELOAD'
+              value: '{{ .Values.eventLogger.configReload }}'
             - name: 'ENABLE_WEBHOOKS'
               value: '{{ .Values.webhook.enabled }}'
             {{- if .Values.eventLogger.leaderElectionResourceLock }}

helm/values.yaml

@@ -28,6 +28,8 @@ eventLogger:
       memory: 256Mi
   # -- Security Context for the logger pods.
   securityContext: {}
+  # -- Watch the configmap for changes.
+  configReload: true
 
 logging: # see https://github.com/operator-framework/operator-sdk/blob/master/doc/user/logging.md
   # -- Log level

pkg/constants/constants.go

@@ -53,6 +53,9 @@ const (
 	// EnvConfigMapName the name of the configmap
 	EnvConfigMapName = "CONFIG_MAP_NAME"
 
+	// EnvConfigReload watch the configmap for changes
+	EnvConfigReload = "CONFIG_RELOAD"
+
 	// ConfigKeyContainerTemplate pod template config key
 	ConfigKeyContainerTemplate = "container_template.yaml"
 )