Skip to content

Commit c83f67a

Browse files
committed
add cron expression to version metric
1 parent fcbe732 commit c83f67a

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

pkg/metrics/metrics.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ const (
1515
labelValueLatest = "latest"
1616
labelExecutionID = "executionID"
1717
labelPrefix = "prefix"
18+
labelCron = "cron"
1819

1920
versionMetric = "com_github_bakito_batch_job_controller"
2021

@@ -167,7 +168,7 @@ func NewPromCollector(cfg *config.Config) (*Collector, error) {
167168
c.versionGauge = prom.NewGaugeVec(prom.GaugeOpts{
168169
Name: versionMetric,
169170
Help: versionHelp,
170-
}, []string{config.LabelVersion, config.LabelName, labelPrefix, config.LabelPoolSize, config.LabelReportHistory})
171+
}, []string{config.LabelVersion, config.LabelName, labelPrefix, config.LabelPoolSize, config.LabelReportHistory, labelCron})
171172

172173
for name, metric := range cfg.Metrics.Gauges {
173174
if name == procErrorMetric || name == durationMetric || name == podsMetric {
@@ -195,6 +196,7 @@ func NewPromCollector(cfg *config.Config) (*Collector, error) {
195196
cfg.Metrics.Prefix,
196197
strconv.Itoa(cfg.PodPoolSize),
197198
strconv.Itoa(cfg.ReportHistory),
199+
cfg.CronExpression,
198200
).Set(1)
199201

200202
return c, nil

pkg/metrics/metrics_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ var _ = Describe("metrics", func() {
1919
var cfg *config.Config
2020
BeforeEach(func() {
2121
cfg = &config.Config{
22-
Metrics: cfgMetrics,
22+
Metrics: cfgMetrics,
23+
CronExpression: "42 3 * * *",
2324
}
2425
})
2526
Context("NewPromCollector", func() {
@@ -133,6 +134,7 @@ var _ = Describe("metrics", func() {
133134
"prefix": cfg.Metrics.Prefix,
134135
"reportHistory": strconv.Itoa(cfg.ReportHistory),
135136
"version": version.Version,
137+
"cron": cfg.CronExpression,
136138
},
137139
"1",
138140
)

0 commit comments

Comments
 (0)