Skip to content
This repository was archived by the owner on Feb 23, 2019. It is now read-only.

Commit df19449

Browse files
committed
Remove admin user controller
1 parent 5d42c4c commit df19449

3 files changed

Lines changed: 7 additions & 74 deletions

File tree

web/controllers/admin/user_controller.ex

Lines changed: 0 additions & 67 deletions
This file was deleted.

web/controllers/auth_controller.ex

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ defmodule Org.AuthController do
1313

1414
def delete(conn, _params) do
1515
conn
16-
|> put_flash(:info, "You have been logged out!")
1716
|> configure_session(drop: true)
1817
|> redirect(to: "/")
1918
end
@@ -38,10 +37,10 @@ defmodule Org.AuthController do
3837
|> redirect(to: "/")
3938
end
4039

41-
defp authorize_url!("github"), do: GitHub.authorize_url!
40+
defp authorize_url!("github"), do: GitHub.authorize_url!
4241
defp authorize_url!(_), do: raise "No matching provider available"
4342

44-
defp get_token!("github", code), do: GitHub.get_token!(code: code)
43+
defp get_token!("github", code), do: GitHub.get_token!(code: code)
4544
defp get_token!(_, _), do: raise "No matching provider available"
4645

4746
defp get_user!("github", token) do
@@ -69,10 +68,11 @@ defmodule Org.AuthController do
6968
end
7069

7170
defp find_or_create_user(user) do
72-
case Repo.get_by(User, github_id: user[:github_id]) do
71+
user = case Repo.get_by(User, github_id: user[:github_id]) do
7372
nil -> %User{} # User not found, we build one
7473
user -> user # User exists, let's use it
7574
end
75+
7676
user
7777
|> User.changeset
7878
|> Repo.insert_or_update!

web/controllers/user_controller.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ defmodule Org.Api.UserController do
3232
|> Repo.get!(id)
3333
|> authorize!(:update, current_user(conn))
3434
|> User.changeset(user_params)
35-
|> update_user(conn, &(render(conn, "show.json", user: &1)))
35+
|> update_user(conn)
3636
end
3737

3838
def apply(conn, %{"id" => id, "user" => user_params}) do
@@ -51,10 +51,10 @@ defmodule Org.Api.UserController do
5151
end
5252
end
5353

54-
defp update_user(changeset, conn, func) do
54+
defp update_user(changeset, conn) do
5555
case Repo.update(changeset) do
5656
{:ok, user} ->
57-
func.(user)
57+
render(conn, "show.json", user: user)
5858
{:error, %{errors: errors}} ->
5959
conn
6060
|> put_status(409)

0 commit comments

Comments
 (0)