chore: fixing the UnsafeUtilTest

Author: Davide Melfi

aws-lambda-java-runtime-interface-client/src/test/java/com/amazonaws/services/lambda/runtime/api/client/util/UnsafeUtilTest.java

@@ -8,6 +8,7 @@
 import org.junit.jupiter.api.Test;
 import java.lang.reflect.Field;
 import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
 
 public class UnsafeUtilTest {
 
@@ -19,7 +20,7 @@ void testTheUnsafeIsInitialized() {
     @Test
     void testThrowException() {
         Exception testException = new Exception("Test exception");
-        
+
         try {
             UnsafeUtil.throwException(testException);
             fail("Should have thrown an exception");
@@ -32,18 +33,34 @@ void testThrowException() {
     @Test
     void testDisableIllegalAccessWarning() {
         assertDoesNotThrow(() -> UnsafeUtil.disableIllegalAccessWarning());
+
+        String specVersion = System.getProperty("java.specification.version");
+        int version = specVersion.startsWith("1.")
+                ? Integer.parseInt(specVersion.substring(2))
+                : Integer.parseInt(specVersion);
+        // we are using assume to skip the test in java8 and java 17+ because the
+        // IllegalAccessorLogger does not exist there.
+        assumeTrue(version >= 9 && version < 17,
+                "IllegalAccessLogger only exists on JDK 9-16");
+
         try {
+
+            // We disable the warning log for "jdk.internal.module.IllegalAccessLogger"
+            UnsafeUtil.disableIllegalAccessWarning();
+
             Class<?> illegalAccessLoggerClass = Class.forName("jdk.internal.module.IllegalAccessLogger");
             Field loggerField = illegalAccessLoggerClass.getDeclaredField("logger");
-            loggerField.setAccessible(true);
-            Object loggerValue = loggerField.get(null);
+
+            // Now we are getting it back with getObjectVolatile and verirfy that the logger
+            // is null. We are not using default reflection because that will throw because
+            // that field is private
+            // defeating the point of the tests.
+            Object loggerValue = UnsafeUtil.TheUnsafe.getObjectVolatile(
+                    illegalAccessLoggerClass,
+                    UnsafeUtil.TheUnsafe.staticFieldOffset(loggerField));
             assertNull(loggerValue);
-        } catch (ClassNotFoundException e) {
-            assertTrue(true);
-        } catch (NoSuchFieldException e) {
-            assertTrue(true);
-        } catch (Exception e) {
-            fail("Unexpected exception: " + e.getMessage());
+        } catch (ClassNotFoundException | NoSuchFieldException e) {
+            fail("IllegalAccessLogger should exist on JDK " + version + ": " + e.getMessage());
         }
     }