|
os.system('pip install paho-mqtt') |
Installs arbitrary packages on to the system.
This is bad in many many ways
- os.system is one of the calls that should not be used without safeguarding
- the libraries are lacking any kind of version pinning, so two consecutive runs might have a completely different output
- the libraries are installed system wide, which might corrupt much on a multi user system
- and in general setup.py should never install packages, just check for there existence
These points make the implementation unusable in a setup that has no network access at build time (Yocto build system for instance)
iotc-python-sdk/iotconnect-sdk-1.0/setup.py
Line 12 in dc94de8
Installs arbitrary packages on to the system.
This is bad in many many ways
These points make the implementation unusable in a setup that has no network access at build time (Yocto build system for instance)