Skip to content

setup.py installs packages while running #3

@kwavnet

Description

@kwavnet

os.system('pip install paho-mqtt')

Installs arbitrary packages on to the system.
This is bad in many many ways

  • os.system is one of the calls that should not be used without safeguarding
  • the libraries are lacking any kind of version pinning, so two consecutive runs might have a completely different output
  • the libraries are installed system wide, which might corrupt much on a multi user system
  • and in general setup.py should never install packages, just check for there existence

These points make the implementation unusable in a setup that has no network access at build time (Yocto build system for instance)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions