Match BEAM binary:split option handling

Signed-off-by: Peter M <petermm@gmail.com>

Author: petermm

src/libAtomVM/nifs.c

@@ -3564,6 +3564,8 @@ static term nif_binary_split(Context *ctx, int argc, term argv[])
         if (UNLIKELY(!term_is_list(options))) {
             RAISE_ERROR(BADARG_ATOM);
         }
+        // Match BEAM semantics and ignore an improper tail after a valid
+        // option prefix, e.g. [global | foo].
         while (term_is_nonempty_list(options)) {
             term head = term_get_list_head(options);
             switch (head) {
@@ -3581,9 +3583,6 @@ static term nif_binary_split(Context *ctx, int argc, term argv[])
             }
             options = term_get_list_tail(options);
         }
-        if (UNLIKELY(!term_is_nil(options))) {
-            RAISE_ERROR(BADARG_ATOM);
-        }
     }
 
     size_t pattern_count = 1;

tests/erlang_tests/test_binary_split.erl

@@ -37,6 +37,7 @@ start() ->
     ok = split_compare_expected([<<"a">>], <<":a::">>, <<":">>, [global, trim_all]),
     ok = split_compare_expected([], <<>>, <<":">>, [trim]),
     ok = split_compare_expected([<<"abc">>], <<"abc">>, [<<"z">>, <<"y">>], [trim_all]),
+    ok = split_compare_expected([<<"a">>], <<"a">>, <<":">>, [global | foo]),
     ok = fail_split(<<>>),
     ok = fail_split([]),
     ok = fail_split([<<>>]),

tests/libs/estdlib/test_binary.erl

@@ -44,7 +44,7 @@ test_split() ->
     ?ASSERT_EXCEPTION(binary:split(<<"a">>, [<<>>]), error, badarg),
     ?ASSERT_EXCEPTION(binary:split(<<"a">>, [foo]), error, badarg),
     ?ASSERT_EXCEPTION(binary:split(<<"a">>, <<":">>, [foo]), error, badarg),
-    ?ASSERT_EXCEPTION(binary:split(<<"a">>, <<":">>, [global | foo]), error, badarg),
+    ?ASSERT_MATCH(binary:split(<<"a">>, <<":">>, [global | foo]), [<<"a">>]),
     ?ASSERT_MATCH(binary:split(<<"aba">>, [<<"a">>, <<"ab">>]), [<<>>, <<"a">>]),
     ?ASSERT_MATCH(binary:split(<<"aba">>, [<<"ab">>, <<"a">>]), [<<>>, <<"a">>]),
     ?ASSERT_MATCH(binary:split(<<":">>, <<":">>, [trim]), []),