Skip to content

Commit f27c7a0

Browse files
committed
Bump to Electron 33.
synchronous-socket depends on nan, which needs to be patched for Electron >= 33. For the complete discussion and a hotfix see: nodejs/nan#978 (comment) Hopefully a PR that fixes it will be merged soon, nodejs/nan#979. Closes #56.
1 parent d9abaf7 commit f27c7a0

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@
1010
},
1111
"homepage": "https://github.com/atlas-engineer/cl-electron/",
1212
"scripts": {
13-
"postinstall": "electron-builder install-app-deps",
13+
"postinstall": "sed 's/^#include .nan_scriptorigin\\.h./\\/\\/ #include nan_scriptorigin.h/' ./node_modules/nan/nan.h > ./node_modules/nan/nan.h.new && mv ./node_modules/nan/nan.h.new ./node_modules/nan/nan.h && electron-builder install-app-deps",
1414
"start": "electron",
1515
"debug": "electron --inspect",
1616
"repl": "electron -i"
1717
},
1818
"devDependencies": {
19-
"electron": "^32.0.0",
19+
"electron": "^33.0.0",
2020
"electron-builder": "^25.0.0"
2121
},
2222
"dependencies": {

0 commit comments

Comments
 (0)