Skip to content

Commit a1deb78

Browse files
committed
fix: Move email constant to strings.xml
The feedback email constant was moved from `constants.kt` to `strings.xml` to align with resource management best practices.
1 parent 8fb884c commit a1deb78

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

app/src/main/java/com/itsaky/androidide/fragments/MainFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ class MainFragment : BaseFragment() {
188188
feedbackIntent.type = "text/plain"
189189
feedbackIntent.putExtra(
190190
Intent.EXTRA_EMAIL,
191-
arrayOf(FEEDBACK_EMAIL)
191+
arrayOf(R.string.feeback_email)
192192
)
193193
feedbackIntent.putExtra(Intent.EXTRA_SUBJECT, subject)
194194
feedbackIntent.putExtra(Intent.EXTRA_TEXT, feedbackMessage)

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,4 +117,5 @@ Connected to the target VM, address: \'localhost:46423\', transport: \'socket\'
117117
<string name="more_label">More</string>
118118
<string name="send_email">Send Email</string>
119119
<string name="close">Close</string>
120+
<string name="feeback_email">feedback@appdevforall.com</string>
120121
</resources>

constants/src/main/java/com/adfa/constants/constants.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,6 @@ const val CONTENT_KEY = "CONTENT_KEY"
151151
// Toml
152152
const val TOML_FILE_NAME = "libs.versions.toml"
153153

154-
//Email constant
155-
const val FEEDBACK_EMAIL = "feedback@appdevforall.com"
156-
157-
158154
// Help
159155
const val HELP_PAGE_URL =
160156
"file:///android_asset/CoGoTooltips/html/cogohelp/index.html"

0 commit comments

Comments
 (0)