fix(dnd): improve external URI parsing and file import safety

Author: jatezzz

app/src/main/java/com/itsaky/androidide/dnd/DragAndDropExtensions.kt

@@ -17,30 +17,34 @@ fun DragEvent.hasImportableContent(context: Context): Boolean {
         DragEvent.ACTION_DROP -> {
             val clip = clipData ?: return false
             (0 until clip.itemCount).any { index ->
-                clip.getItemAt(index).toImportableExternalUri(context) != null
+                clip.getItemAt(index).toImportableExternalUris(context).isNotEmpty()
             }
         }
         else -> clipDescription?.hasImportableMimeType() == true
     }
 }
 
 /**
- * Resolves the [ClipData.Item] to an external [Uri], ignoring internal application URIs.
+ * Resolves the [ClipData.Item] to a list of external [Uri]s, ignoring internal application URIs.
  */
-fun ClipData.Item.toImportableExternalUri(context: Context): Uri? {
-    val resolvedUri = toExternalUri() ?: return null
-    return resolvedUri.takeUnless { it.isInternalDragUri(context) }
+fun ClipData.Item.toImportableExternalUris(context: Context): List<Uri> {
+    return toExternalUris().filterNot { it.isInternalDragUri(context) }
 }
 
 private fun Uri.isInternalDragUri(context: Context): Boolean {
     return authority == "${context.packageName}.providers.fileprovider"
 }
 
-private fun ClipData.Item.toExternalUri(): Uri? {
-    return uri
-        ?: text?.toString()
-            ?.takeIf { it.startsWith("content://") || it.startsWith("file://") }
-            ?.toUri()
+private fun ClipData.Item.toExternalUris(): List<Uri> {
+    uri?.let { return listOf(it) }
+
+    val textContent = text?.toString() ?: return emptyList()
+
+    return textContent.lineSequence()
+        .map { it.trim() }
+        .filter { it.startsWith("content://") || it.startsWith("file://") }
+        .map { it.toUri() }
+        .toList()
 }
 
 private fun ClipDescription.hasImportableMimeType(): Boolean {

app/src/main/java/com/itsaky/androidide/dnd/DropTargetCallback.kt

@@ -29,7 +29,7 @@ interface DropTargetCallback {
 
     /**
      * Called when the user successfully drops a valid item on the target.
-     * * @return True if the drop was successfully consumed and handled.
+     * @return True if the drop was successfully consumed and handled.
      */
     fun onDrop(event: DragEvent): Boolean
 }

app/src/main/java/com/itsaky/androidide/utils/FileImporter.kt

@@ -3,7 +3,7 @@ package com.itsaky.androidide.utils
 import android.content.ClipData
 import android.content.Context
 import com.itsaky.androidide.R
-import com.itsaky.androidide.dnd.toImportableExternalUri
+import com.itsaky.androidide.dnd.toImportableExternalUris
 import java.io.File
 
 /**
@@ -28,10 +28,10 @@ class FileImporter(private val context: Context) {
         }
 
         val validUris = (0 until clipData.itemCount)
-            .mapNotNull { clipData.getItemAt(it).toImportableExternalUri(context) }
+            .flatMap { clipData.getItemAt(it).toImportableExternalUris(context) }
 
         if (validUris.isEmpty()) {
-            return ImportResult.Failure(IllegalArgumentException("No importable files found"))
+            return ImportResult.Failure(IllegalArgumentException(context.getString(R.string.msg_file_tree_drop_no_files)))
         }
 
         val results = validUris.map { uri ->
@@ -50,7 +50,9 @@ class FileImporter(private val context: Context) {
                     context = context,
                     uri = uri,
                     destinationFile = destinationFile,
-                    onOpenFailed = { IllegalStateException("Unable to open URI: $sanitizedName") }
+                    onOpenFailed = { IllegalStateException(
+                        context.getString(R.string.msg_file_tree_drop_read_failed, sanitizedName)
+                    )}
                 )
             }
         }

app/src/main/java/com/itsaky/androidide/utils/UriFileImporter.kt

@@ -32,11 +32,21 @@ object UriFileImporter {
     destinationFile: File,
     onOpenFailed: (() -> Throwable)? = null,
   ) {
-    contentResolver.openInputStream(uri)?.use { input ->
-      destinationFile.outputStream().use { output ->
-        input.copyTo(output)
+    val inputStream = contentResolver.openInputStream(uri)
+      ?: throw (onOpenFailed?.invoke() ?: IllegalStateException("Unable to open URI: $uri"))
+
+    try {
+      inputStream.use { input ->
+        destinationFile.outputStream().use { output ->
+          input.copyTo(output)
+        }
+      }
+    } catch (e: Exception) {
+      if (destinationFile.exists()) {
+        destinationFile.delete()
       }
-    } ?: throw (onOpenFailed?.invoke() ?: IllegalStateException("Unable to open URI: $uri"))
+      throw e
+    }
   }
 
   @JvmStatic