Rename crawler_id to just id

Author: Pijukatel

src/crawlee/crawlers/_basic/_basic_crawler.py

@@ -298,7 +298,7 @@ def __init__(
         status_message_logging_interval: timedelta = timedelta(seconds=10),
         status_message_callback: Callable[[StatisticsState, StatisticsState | None, str], Awaitable[str | None]]
         | None = None,
-        crawler_id: int | None = None,
+        id: int | None = None,
         _context_pipeline: ContextPipeline[TCrawlingContext] | None = None,
         _additional_context_managers: Sequence[AbstractAsyncContextManager] | None = None,
         _logger: logging.Logger | None = None,
@@ -351,7 +351,7 @@ def __init__(
             status_message_logging_interval: Interval for logging the crawler status messages.
             status_message_callback: Allows overriding the default status message. The default status message is
                 provided in the parameters. Returning `None` suppresses the status message.
-            crawler_id: Id of the crawler used for state and statistics tracking. You can use same explicit id to share
+            id: Id of the crawler used for state and statistics tracking. You can use same explicit id to share
                 state and statistics between two crawlers. By default, each crawler will use own state and statistics.
             _context_pipeline: Enables extending the request lifecycle and modifying the crawling context.
                 Intended for use by subclasses rather than direct instantiation of `BasicCrawler`.
@@ -360,12 +360,12 @@ def __init__(
             _logger: A logger instance, typically provided by a subclass, for consistent logging labels.
                 Intended for use by subclasses rather than direct instantiation of `BasicCrawler`.
         """
-        if crawler_id is None:
+        if id is None:
             # This could look into set of already used ids, but lets not overengineer this.
             self.id = BasicCrawler.__next_id
             BasicCrawler.__next_id += 1
         else:
-            self.id = crawler_id
+            self.id = id
 
         implicit_event_manager_with_explicit_config = False
         if not configuration:

tests/unit/crawlers/_basic/test_basic_crawler.py

@@ -821,8 +821,8 @@ async def handler(context: BasicCrawlingContext) -> None:
         assert isinstance(state['urls'], list)
         state['urls'].append(context.request.url)
 
-    crawler_1 = BasicCrawler(crawler_id=0, request_handler=handler)
-    crawler_2 = BasicCrawler(crawler_id=0, request_handler=handler)
+    crawler_1 = BasicCrawler(id=0, request_handler=handler)
+    crawler_2 = BasicCrawler(id=0, request_handler=handler)
 
     await crawler_1.run(['https://a.com'])
     await crawler_2.run(['https://b.com'])
@@ -838,8 +838,8 @@ async def test_crawlers_share_stats() -> None:
     async def handler(context: BasicCrawlingContext) -> None:
         await context.use_state({'urls': []})
 
-    crawler_1 = BasicCrawler(crawler_id=0, request_handler=handler)
-    crawler_2 = BasicCrawler(crawler_id=0, request_handler=handler, statistics=crawler_1.statistics)
+    crawler_1 = BasicCrawler(id=0, request_handler=handler)
+    crawler_2 = BasicCrawler(id=0, request_handler=handler, statistics=crawler_1.statistics)
 
     result1 = await crawler_1.run(['https://a.com'])
     result2 = await crawler_2.run(['https://b.com'])