Fix issue where errors may be reported multiple times.

Author: Michael Whapples

src/convert2ebrl/main_window.py

@@ -26,6 +26,7 @@ def on_update_available(v):
                 QDesktopServices.openUrl(QUrl(make_qurl(download_site, "download.html")))
         update_checker.updateAvailable.connect(on_update_available)
         update_checker.noUpdateAvailable.connect(lambda: QMessageBox.information(self, "No updates", "You are running the latest version of the software."))
+        update_checker.errorOccurred.connect(lambda x: QMessageBox.warning(self, "Unable to check for updates.", "There was a problem whilst checking for updates, please try again later."))
         update_check_action = QAction("Check for updates", self)
         download_url = make_qurl(download_site, "metadata.properties")
         update_check_action.triggered.connect(lambda _: update_checker.check_for_update(download_url))

src/convert2ebrl/update_checker.py

@@ -30,7 +30,7 @@ def check_for_update(self, update_url: QUrl):
     @Slot()
     def on_ready_read(self):
         if self.reply:
-            if self.reply.error() == QNetworkReply.NetworkError.NoError:
+            if self.reply.error() == QNetworkReply.NetworkError.NoError and self.reply.attribute(QNetworkRequest.Attribute.HttpStatusCodeAttribute) == 200:
                 response_text = str(self.reply.readAll(), "utf-8")
                 if m := _APP_VERSION_RE.search(response_text):
                     if Version(QCoreApplication.applicationVersion()) < Version(m.group(1)):
@@ -39,10 +39,6 @@ def on_ready_read(self):
                         self.noUpdateAvailable.emit()
                 else:
                     self.errorOccurred.emit("Unable to find latest version")
-            else:
-                self.errorOccurred.emit(self.reply.errorString())
-        else:
-            self.errorOccurred.emit("Unknown error")
     @Slot()
     def on_finished(self):
         if self.reply: