Skip to content

Commit 3043ed3

Browse files
author
Michael Whapples
committed
Fix issue where empty images directory did not have convert button disabled.
1 parent 8606f3a commit 3043ed3

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

src/convert2ebrl/tabs/general_tab.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
from convert2ebrl.settings.keys import CONVERSION_LAST_DIR as LAST_DIR_SETTING_KEY
1515
from convert2ebrl.widgets import FilePickerWidget
1616

17+
1718
class ConversionGeneralSettingsWidget(QWidget):
1819
inputBrfChanged = Signal(str)
1920
imagesDirectoryChanged = Signal(str)
@@ -65,11 +66,14 @@ def on_input_type_changed(index):
6566
settings = QSettings()
6667
settings.setValue("Conversion/input_type", bool(index))
6768
self._input_type_combo.currentIndexChanged.connect(on_input_type_changed)
68-
self._include_images_checkbox.toggled.connect(self._update_include_images_state)
6969
self._input_type_combo.currentIndexChanged.connect(self._clear_input_brf)
7070
self._input_brf_edit.fileChanged.connect(self.inputBrfChanged.emit)
7171
self._input_brf_edit.fileChanged.connect(self._update_output_based_on_input)
72-
self._image_dir_edit.fileChanged.connect(self.imagesDirectoryChanged.emit)
72+
self._include_images_checkbox.toggled.connect(self._update_include_images_state)
73+
def on_image_directory_changed(value: str):
74+
if self._include_images_checkbox.isChecked():
75+
self.imagesDirectoryChanged.emit(value)
76+
self._image_dir_edit.fileChanged.connect(on_image_directory_changed)
7377
self._output_ebrf_edit.fileChanged.connect(self.outputEbrfChanged.emit)
7478

7579
def _update_output_based_on_input(self):
@@ -88,6 +92,7 @@ def _update_include_images_state(self, checked: bool):
8892
self._image_dir_edit.setEnabled(checked)
8993
if not checked:
9094
self._image_dir_edit.file_name = ""
95+
self.imagesDirectoryChanged.emit(self.image_directory)
9196

9297
def _get_input_brf_from_user(self, x) -> list[str]:
9398
settings = QSettings()

0 commit comments

Comments
 (0)