TS-5009 CID 1022011 Logically dead code removal

ngara · ngara · commit b653d000223d · 2016-10-27T16:56:58.000Z
diff --git a/iocore/eventsystem/P_IOBuffer.h b/iocore/eventsystem/P_IOBuffer.h
@@ -684,8 +684,7 @@ IOBufferReader::consume(int64_t n)
 
 TS_INLINE char &IOBufferReader::operator[](int64_t i)
 {
-  static char _error = '\0';
-  IOBufferBlock *b   = block.get();
+  IOBufferBlock *b = block.get();
 
   i += start_offset;
   while (b) {
@@ -696,12 +695,7 @@ TS_INLINE char &IOBufferReader::operator[](int64_t i)
     b = b->next.get();
   }
 
-  ink_assert(!"out of range");
-  if (unlikely(b)) {
-    return *b->start();
-  }
-
-  return _error;
+  ink_release_assert(!"out of range");
 }
 
 TS_INLINE void

Original file line number	Diff line number	Diff line change
`@@ -684,8 +684,7 @@ IOBufferReader::consume(int64_t n)`
`684`	`684`
`685`	`685`	`TS_INLINE char &IOBufferReader::operator[](int64_t i)`
`686`	`686`	`{`
`687`		`- static char _error = '\0';`
`688`		`- IOBufferBlock *b = block.get();`
	`687`	`+ IOBufferBlock *b = block.get();`
`689`	`688`
`690`	`689`	`i += start_offset;`
`691`	`690`	`while (b) {`
`@@ -696,12 +695,7 @@ TS_INLINE char &IOBufferReader::operator[](int64_t i)`
`696`	`695`	`b = b->next.get();`
`697`	`696`	`}`
`698`	`697`
`699`		`- ink_assert(!"out of range");`
`700`		`- if (unlikely(b)) {`
`701`		`- return *b->start();`
`702`		`- }`
`703`		`-`
`704`		`- return _error;`
	`698`	`+ ink_release_assert(!"out of range");`
`705`	`699`	`}`
`706`	`700`
`707`	`701`	`TS_INLINE void`