Skip to content

Commit 94a295a

Browse files
committed
Avoid changing channel state on reset(null,null)
BZ69938
1 parent 1d0aeaf commit 94a295a

2 files changed

Lines changed: 11 additions & 5 deletions

File tree

java/org/apache/tomcat/util/net/SecureNioChannel.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,13 @@ public SecureNioChannel(SocketBufferHandler bufHandler, NioEndpoint endpoint) {
9494
public void reset(SocketChannel channel, NioSocketWrapper socketWrapper) throws IOException {
9595
super.reset(channel, socketWrapper);
9696
sslEngine = null;
97-
sniComplete = false;
98-
handshakeComplete = false;
99-
closed = false;
100-
closing = false;
101-
netInBuffer.clear();
97+
if (channel != null) {
98+
sniComplete = false;
99+
handshakeComplete = false;
100+
closed = false;
101+
closing = false;
102+
netInBuffer.clear();
103+
}
102104
}
103105

104106
@Override

webapps/docs/changelog.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,10 @@
228228
shutdown that triggered a significant memory leak. Patch provided by
229229
Wes. (markt)
230230
</fix>
231+
<fix>
232+
<bug>69938</bug>: Avoid changing the closed state of TLS channel when
233+
resetting it after close. (remm)
234+
</fix>
231235
</changelog>
232236
</subsection>
233237
<subsection name="Jasper">

0 commit comments

Comments
 (0)