From 06237e8387871c1e0398682e7e7dc7894ef5fa80 Mon Sep 17 00:00:00 2001 From: David Smiley Date: Sat, 1 Aug 2026 20:46:21 -0400 Subject: [PATCH] Flaky test TestDistributedGrouping timeAllowed Need higher timeout; 200 isn't enough. 10_000 is plenty; doesn't slow down tests. --- solr/core/src/test/org/apache/solr/TestDistributedGrouping.java | 2 +- solr/core/src/test/org/apache/solr/TestGroupingSearch.java | 2 +- solr/core/src/test/org/apache/solr/search/TestQueryLimits.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/solr/core/src/test/org/apache/solr/TestDistributedGrouping.java b/solr/core/src/test/org/apache/solr/TestDistributedGrouping.java index 132b21784e09..2d989d720da9 100644 --- a/solr/core/src/test/org/apache/solr/TestDistributedGrouping.java +++ b/solr/core/src/test/org/apache/solr/TestDistributedGrouping.java @@ -1300,7 +1300,7 @@ public void test() throws Exception { "cache", "false", "timeAllowed", - "200", + "10000", // generous; queries must complete fully even on slow CI "sleep", "10"); assertFalse( diff --git a/solr/core/src/test/org/apache/solr/TestGroupingSearch.java b/solr/core/src/test/org/apache/solr/TestGroupingSearch.java index c408cfc33322..0f4d51b936c8 100644 --- a/solr/core/src/test/org/apache/solr/TestGroupingSearch.java +++ b/solr/core/src/test/org/apache/solr/TestGroupingSearch.java @@ -481,7 +481,7 @@ public void testGroupingWithTimeAllowed() throws Exception { "group.query", "id:2", "timeAllowed", - "200"), + "10000"), // generous; must complete fully even on slow CI "/grouped/id:1/matches==5", "/grouped/id:2/matches==5"); } diff --git a/solr/core/src/test/org/apache/solr/search/TestQueryLimits.java b/solr/core/src/test/org/apache/solr/search/TestQueryLimits.java index 2e6d773924eb..2a868b2d65e0 100644 --- a/solr/core/src/test/org/apache/solr/search/TestQueryLimits.java +++ b/solr/core/src/test/org/apache/solr/search/TestQueryLimits.java @@ -114,7 +114,7 @@ public void testQueryLimits() throws Exception { @Test public void testAdjustShardRequestLimits() throws Exception { SolrClient solrClient = cluster.getSolrClient(); - String timeAllowed = "1000"; // ms - increased from 500 to avoid flakiness with grouped queries + String timeAllowed = "10000"; // ms - generous; must complete fully even on slow CI ModifiableSolrParams params = params( "q",