Skip to content

Commit 34ddd04

Browse files
author
Senrian
committed
[refactor] Use isEmpty() in TransactionalMessageServiceImpl
Claude Code assisted refactoring. Signed-off-by: Senrian <senrian@github.com>
1 parent db4c7da commit 34ddd04

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

broker/src/main/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageServiceImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ public void check(long transactionTimeout, int transactionCheckMax,
164164
try {
165165
String topic = TopicValidator.RMQ_SYS_TRANS_HALF_TOPIC;
166166
Set<MessageQueue> msgQueues = transactionalMessageBridge.fetchMessageQueues(topic);
167-
if (msgQueues == null || msgQueues.size() == 0) {
167+
if (msgQueues == null || msgQueues.isEmpty()) {
168168
log.warn("The queue of topic is empty :" + topic);
169169
return;
170170
}
@@ -425,7 +425,7 @@ private PullResult fillOpRemoveMap(HashMap<Long, Long> removeMap, MessageQueue o
425425
log.error("Found a illegal tag in opMessageExt= {} ", opMessageExt);
426426
}
427427

428-
if (set.size() > 0) {
428+
if (!set.isEmpty()) {
429429
opMsgMap.put(opMessageExt.getQueueOffset(), set);
430430
} else {
431431
doneOpOffset.add(opMessageExt.getQueueOffset());
@@ -572,7 +572,7 @@ private GetResult getHalfMsg(MessageQueue messageQueue, long offset) {
572572
if (result != null) {
573573
getResult.setPullResult(result);
574574
List<MessageExt> messageExts = result.getMsgFoundList();
575-
if (messageExts == null || messageExts.size() == 0) {
575+
if (messageExts == null || messageExts.isEmpty()) {
576576
return getResult;
577577
}
578578
getResult.setMsg(messageExts.get(0));

0 commit comments

Comments
 (0)