Skip to content

Commit cfa592c

Browse files
committed
improve doc
1 parent 6f471c3 commit cfa592c

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

pip/pip-452.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ message CommandGetTopicsOfNamespace {
4949

5050
Add `properties` parameter to the REST API endpoint for listing topics in a namespace to list topic with specific properties for customizable topic listing.
5151

52-
REST API:
52+
REST API (URL encoding is required for values):
5353
```
54-
GET /admin/v2/persistent/{tenant}/{namespace} with a query params properties=k1=v1,k2=v2
54+
GET /admin/v2/persistent/{tenant}/{namespace}?properties=k1=v1,k2=v2
5555
```
5656

5757
CLI:
@@ -212,14 +212,15 @@ The regex consumer implementation (PatternMultiTopicsConsumerImpl) will be updat
212212

213213
```Java
214214
// In PatternMultiTopicsConsumerImpl.java
215+
ConsumerConfigurationData conf;
215216
Map<String, String> contextProperties = conf.getProperties();
216217

217218
lookup.getTopicsUnderNamespace(
218219
namespace,
219220
mode,
220221
topicsPattern.pattern(),
221222
topicsHash,
222-
contextProperties // Pass properties here
223+
contextProperties // Pass consumer properties here
223224
).thenAccept(topics -> {
224225
// ... update subscriptions ...
225226
});
@@ -238,5 +239,5 @@ Authorization: This PIP only controls the discovery (listing) of topics. It does
238239

239240
# Links
240241

241-
* Mailing List discussion thread:
242+
* Mailing List discussion thread: https://lists.apache.org/thread/nf11qzn6r9wps6l81trxwtdr1m9xszpm
242243
* Mailing List voting thread:

0 commit comments

Comments
 (0)