From f6d527f3c1bd1acbb9f4d252dbfbda60f3ac5a8b Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Thu, 20 Aug 2026 02:54:50 +0000 Subject: [PATCH] fix(parquet): pass ReadHints into VECTOR ParquetFileBatchReader tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #198 landed after #209 made ReadHints a required Create() argument. The new VECTOR tests still used the old 6-argument call, so main CI failed to compile parquet_vector_io_test.cpp. Co-authored-by: 小明同学 --- src/paimon/format/parquet/parquet_vector_io_test.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/paimon/format/parquet/parquet_vector_io_test.cpp b/src/paimon/format/parquet/parquet_vector_io_test.cpp index e177cc1b..f45dad1e 100644 --- a/src/paimon/format/parquet/parquet_vector_io_test.cpp +++ b/src/paimon/format/parquet/parquet_vector_io_test.cpp @@ -155,7 +155,8 @@ class ParquetVectorIoTest : public ::testing::Test { std::unique_ptr reader, ParquetFileBatchReader::Create(std::move(in_stream), /*options=*/{}, /*batch_size=*/10, /*file_metadata=*/nullptr, - /*storage_read_bytes=*/nullptr, arrow_pool_)); + /*storage_read_bytes=*/nullptr, arrow_pool_, + /*hints=*/std::nullopt)); ASSERT_OK_AND_ASSIGN(std::unique_ptr c_file_schema, reader->GetFileSchema()); arrow::Result> file_type_result = arrow::ImportType(c_file_schema.get()); @@ -176,7 +177,8 @@ class ParquetVectorIoTest : public ::testing::Test { std::unique_ptr reader, ParquetFileBatchReader::Create(std::move(in_stream), options, batch_size, /*file_metadata=*/nullptr, - /*storage_read_bytes=*/nullptr, arrow_pool_)); + /*storage_read_bytes=*/nullptr, arrow_pool_, + /*hints=*/std::nullopt)); std::unique_ptr vector_reader = std::make_unique(std::move(reader), pool_); auto c_schema = std::make_unique();