fix(format): retain release array validation

Author: gripleaf

src/paimon/format/orc/orc_adapter.cpp

@@ -940,10 +940,9 @@ Result<std::shared_ptr<arrow::Array>> OrcAdapter::AppendBatch(
                            MakeArrowBuilder(type, batch, pool));
     std::shared_ptr<arrow::Array> array;
     PAIMON_RETURN_NOT_OK_FROM_ARROW(builder->Finish(&array));
-#ifndef NDEBUG
-    // Keep structural validation in debug builds without adding its recursive cost to reads.
+    // Keep this check in release builds so malformed nested arrays return a Status before they
+    // reach Arrow constructors that enforce their invariants with a process-terminating check.
     PAIMON_RETURN_NOT_OK_FROM_ARROW(array->Validate());
-#endif
     return array;
 }
 

src/paimon/format/parquet/parquet_file_batch_reader.cpp

@@ -616,10 +616,7 @@ Result<BatchReader::ReadBatch> ParquetFileBatchReader::NextBatch() {
         }
         PAIMON_ASSIGN_OR_RAISE_FROM_ARROW(std::shared_ptr<arrow::Array> array,
                                           batch->ToStructArray());
-#ifndef NDEBUG
-        // Keep structural validation in debug builds without adding its recursive cost to reads.
         PAIMON_RETURN_NOT_OK_FROM_ARROW(array->Validate());
-#endif
         PAIMON_ASSIGN_OR_RAISE(bool need_cast, ParquetTimestampConverter::NeedCastArrayForTimestamp(
                                                    array->type(), read_data_type_));
         if (need_cast) {