Tests for Ant projects no longer work with bundled TestNG libraries

[gem-bricks]

Apache NetBeans version

Apache NetBeans 31

What happened

Using ant test or running individual tests in the IDE yields an error with an Ant project that uses the bundled TestNG libraries (added with Test Dependencies > Add Library...).

Language / Project Type / NetBeans Component

Ant project using TestNG

How to reproduce

1. Create a new Ant project (New Project... > Java with Ant > Java Application). Keep Create Main Class checked.
2. In the main class, click on the class name and select Create Test Class [TestNG... in the hints.
3. Test the testMain method.

Did this work correctly in an earlier version?

Apache NetBeans 30

Operating System

linux 7.1.8.arch1-3

JDK

OpenJDK 26.0.2.u10-1

Apache NetBeans packaging

Community provided installer, Third-party package

Anything else

Example project

It has broken with 31 because TestNG has been bumped up to 7.11. The current build-impl.xml isn't equipped to handle the new major version.

Related to this issue.

Test output:

SLF4J(W): No SLF4J providers were found.
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
Exception in thread "main" org.testng.TestNGException: 
Couldn't find a constructor in class org.testng.reporters.VerboseReporter
	at org.testng.internal.objects.InstanceCreator.newInstance(InstanceCreator.java:59)
	at org.testng.ITestObjectFactory.newInstance(ITestObjectFactory.java:10)
	at org.testng.internal.objects.SimpleObjectDispenser.dispense(SimpleObjectDispenser.java:61)
	at org.testng.internal.objects.GuiceBasedObjectDispenser.dispenseObject(GuiceBasedObjectDispenser.java:41)
	at org.testng.internal.objects.GuiceBasedObjectDispenser.dispense(GuiceBasedObjectDispenser.java:31)
	at org.testng.internal.DefaultListenerFactory.createListener(DefaultListenerFactory.java:29)
	at org.testng.TestNG.setListenerClasses(TestNG.java:698)
	at org.testng.TestNG.configure(TestNG.java:1558)
	at org.testng.TestNG.privateMain(TestNG.java:1421)
	at org.testng.TestNG.main(TestNG.java:1394)

Are you willing to submit a pull request?

Yes

[matthiasblaesing]

This is most probably a fallout from #9254. Grepping through the codebase indicates, that the problem might be much bigger (grep -r org.testng.reporters.VerboseReporter * | grep -v "/test/").

The minimal change I had to do to get basic execution working again was:

diff --git a/java/java.j2seproject/src/org/netbeans/modules/java/j2seproject/resources/build-impl.xsl b/java/java.j2seproject/src/org/netbeans/modules/java/j2seproject/resources/build-impl.xsl
index 7c4c00edb667..bc94091512a6 100644
--- a/java/java.j2seproject/src/org/netbeans/modules/java/j2seproject/resources/build-impl.xsl
+++ b/java/java.j2seproject/src/org/netbeans/modules/java/j2seproject/resources/build-impl.xsl
@@ -1148,8 +1148,8 @@ is divided into following sections:
                         </union>
                         <taskdef name="testng" classname="org.testng.TestNGAntTask" classpath="${{run.test.classpath}}"/>
                         <testng>
-                            <xsl:attribute name="listeners">org.testng.reporters.VerboseReporter</xsl:attribute>
                             <xsl:attribute name="mode">${testng.mode}</xsl:attribute>
+                            <xsl:attribute name="verbose">5</xsl:attribute>
                             <xsl:attribute name="classfilesetref">test.set</xsl:attribute>
                             <xsl:attribute name="workingDir">${work.dir}</xsl:attribute> <!-- #47474: match <java> --> 
                             <xsl:attribute name="failureProperty">tests.failed</xsl:attribute>
@@ -1369,7 +1369,7 @@ is divided into following sections:
                                 <jvmarg value="-ea"/>
                                 <arg line="${{testng.debug.mode}}"/>
                                 <arg line="-d ${{build.test.results.dir}}"/>
-                                <arg line="-listener org.testng.reporters.VerboseReporter"/>
+                                <arg line="-verbose 5"/>
                                 <arg line="${{testng.cmd.args}}"/>
                             </customizeDebuggee>
                         </j2seproject3:debug>
diff --git a/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-debug-snippet.xml b/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-debug-snippet.xml
index e5c5a97df7cb..82040b057e23 100644
--- a/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-debug-snippet.xml
+++ b/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-debug-snippet.xml
@@ -210,7 +210,7 @@
                     </syspropertyset>
                     <arg line="${testng.mode}"/>
                     <arg line="-d ${test.results.dir}"/>
-                    <arg line="-listener org.testng.reporters.VerboseReporter"/>
+                    <arg line="-verbose 5"/>
                     <arg line="${testng.cmd.args}"/>                                                                                                                                                                                                                                             
                 </java>
                 <delete dir="${test.results.dir}" quiet="true"/>
diff --git a/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-profile-snippet.xml b/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-profile-snippet.xml
index 96d3e2097006..03636f5e3e33 100644
--- a/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-profile-snippet.xml
+++ b/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-profile-snippet.xml
@@ -190,7 +190,7 @@
                     </syspropertyset>
                     <arg line="${testng.mode}"/>
                     <arg line="-d ${test.result.dir}"/>
-                    <arg line="-listener org.testng.reporters.VerboseReporter"/>
+                    <arg line="-verbose 5"/>
                     <arg line="${testng.cmd.args}"/>
                 </java>
                 <delete dir="${test.result.dir}" quiet="true"/>
diff --git a/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-snippet.xml b/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-snippet.xml
index 0a50b31b6eb8..2ff989e00f62 100644
--- a/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-snippet.xml
+++ b/java/java.source.ant/src/org/netbeans/modules/java/source/ant/resources/junit-snippet.xml
@@ -171,7 +171,7 @@
                     </syspropertyset>
                     <arg line="${testng.mode}"/>
                     <arg line="-d ${test.result.dir}"/>
-                    <arg line="-listener org.testng.reporters.VerboseReporter"/>
+                    <arg line="-verbose 5"/>
                     <arg line="${testng.cmd.args}"/>
                 </java>
                 <delete dir="${test.result.dir}" quiet="true"/>

@sid-srini I think the hard part will be to find the other places that need love