fix: align multitarget branch with marker-based catch-up provider contract

Adopt the marker-interface catch-up provider shape in lucene9 editor wiring and remove obsolete tests tied to the old createCatchUpEditor API.

Made-with: Cursor

Author: bhabegger

oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/CatchUpCapableTest.java

@@ -64,10 +64,15 @@ public Editor getIndexEditor(@NotNull String type,
             return null;
         }
 
-        // Guard: skip this target while a catch-up is in progress for it
-        if (definition.getChildNode(CatchUpCapable.CATCH_UP_TRACKING_NODE)
-                .hasProperty(LuceneNgIndexConstants.TYPE_LUCENE9)) {
-            return null;
+        // Guard: skip normal indexing if catch-up is in progress for this target
+        // But allow catch-up itself to run (catch-up passes the targetType as the type parameter)
+        NodeBuilder trackingNode = definition.getChildNode(CatchUpCapable.CATCH_UP_TRACKING_NODE);
+        if (trackingNode.exists() && trackingNode.hasProperty(LuceneNgIndexConstants.TYPE_LUCENE9)) {
+            // If type == "lucene9", this is a catch-up call, allow it
+            // If type != "lucene9", this is normal indexing, block it
+            if (!LuceneNgIndexConstants.TYPE_LUCENE9.equals(type)) {
+                return null; // Block normal indexing while catch-up is in progress
+            }
         }
 
         String indexPath = "/oak:index/unknown";
@@ -101,37 +106,7 @@ public Editor getIndexEditor(@NotNull String type,
         }
     }
 
-    @Override
-    @Nullable
-    public Editor createCatchUpEditor(
-            @NotNull String targetType,
-            @NotNull String indexName,
-            @NotNull NodeBuilder definition,
-            @NotNull NodeBuilder rootBuilder,
-            @NotNull NodeState root,
-            @NotNull IndexUpdateCallback callback)
-            throws CommitFailedException {
-
-        if (!LuceneNgIndexConstants.TYPE_LUCENE9.equals(targetType)) {
-            return null;
-        }
-        if (!IndexDefinitionHelper.shouldWrite(definition.getNodeState(), LuceneNgIndexConstants.TYPE_LUCENE9)) {
-            return null;
-        }
-
-        // NOTE: intentionally does NOT check the tracking node —
-        // CatchUpRunner owns the tracking state.
-        String indexPath = "/oak:index/" + indexName;
-        NodeBuilder storageBuilder = getOrCreateStorageBuilder(rootBuilder, indexName);
 
-        LOG.debug("Creating catch-up Lucene9 editor for {}", indexPath);
-        try {
-            return new LuceneNgIndexEditor("/", indexPath, storageBuilder, definition, root, false, callback);
-        } catch (Exception e) {
-            throw new CommitFailedException("Lucene9", 2,
-                    "Failed to create catch-up LuceneNgIndexEditor for " + indexPath, e);
-        }
-    }
 
     /**
      * Returns the NodeBuilder for the index storage path, creating intermediate