Skip to content

Commit ee33e03

Browse files
committed
use strings for HTTP methods
1 parent 2db87f2 commit ee33e03

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

core/src/test/java/org/apache/iceberg/rest/RemoteSignerServlet.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import jakarta.servlet.http.HttpServletResponse;
2828
import java.io.InputStreamReader;
2929
import java.io.Reader;
30-
import java.util.EnumSet;
30+
import java.util.Locale;
3131
import java.util.Map;
3232
import java.util.Set;
3333
import org.apache.hc.core5.http.ContentType;
@@ -57,8 +57,7 @@ public abstract class RemoteSignerServlet extends HttpServlet {
5757
private static final String CACHE_CONTROL_PRIVATE = "private";
5858
private static final String CACHE_CONTROL_NO_CACHE = "no-cache";
5959

60-
private static final Set<HttpMethod> CACHEABLE_METHODS =
61-
EnumSet.of(HttpMethod.GET, HttpMethod.HEAD);
60+
private static final Set<String> CACHEABLE_METHODS = Set.of("GET", "HEAD");
6261

6362
private static final Map<String, String> RESPONSE_HEADERS =
6463
ImmutableMap.of(HttpHeaders.CONTENT_TYPE, ContentType.APPLICATION_JSON.getMimeType());
@@ -115,7 +114,7 @@ protected void validateSignRequest(RemoteSignRequest request) {
115114
* @param response the HTTP response to add headers to
116115
*/
117116
protected void addSignResponseHeaders(RemoteSignRequest request, HttpServletResponse response) {
118-
if (CACHEABLE_METHODS.contains(HttpMethod.valueOf(request.method()))) {
117+
if (CACHEABLE_METHODS.contains(request.method().toUpperCase(Locale.ROOT))) {
119118
// tell the client this can be cached
120119
response.setHeader(CACHE_CONTROL, CACHE_CONTROL_PRIVATE);
121120
} else {

0 commit comments

Comments
 (0)