Normalize the byte buffer when constructing BoundingBoxLiteral

Author: Kontinuation

api/src/main/java/org/apache/iceberg/expressions/Literals.java

@@ -22,6 +22,7 @@
 import java.math.BigDecimal;
 import java.math.RoundingMode;
 import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
 import java.time.Instant;
 import java.time.LocalDate;
 import java.time.LocalTime;
@@ -734,7 +735,8 @@ static class BoundingBoxLiteral implements Literal<ByteBuffer> {
     }
 
     BoundingBoxLiteral(ByteBuffer value) {
-      this.value = value;
+      Preconditions.checkNotNull(value, "Bounding box buffer cannot be null");
+      this.value = value.slice().order(ByteOrder.LITTLE_ENDIAN);
     }
 
     @Override

api/src/test/java/org/apache/iceberg/expressions/TestExpressionUtil.java

@@ -21,6 +21,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
 import java.time.LocalDate;
 import java.time.OffsetDateTime;
 import java.time.ZoneOffset;
@@ -1393,6 +1394,22 @@ public void testSanitizeGeospatialPredicates(
         .isEqualTo(expectedSanitizedString);
   }
 
+  @Test
+  public void testBoundingBoxLiteralNormalizesBuffer() {
+    GeospatialBound min = GeospatialBound.createXY(1.0, 2.0);
+    GeospatialBound max = GeospatialBound.createXY(3.0, 4.0);
+    BoundingBox box = new BoundingBox(min, max);
+    ByteBuffer serialized = box.toByteBuffer();
+
+    ByteBuffer padded = ByteBuffer.allocate(serialized.remaining() + 1).order(ByteOrder.BIG_ENDIAN);
+    padded.put((byte) 0x0);
+    padded.put(serialized.duplicate());
+    padded.position(1);
+    Literal<ByteBuffer> literal = new Literals.BoundingBoxLiteral(padded);
+
+    assertThat(literal.toString()).isEqualTo(box.toString());
+  }
+
   private void assertEquals(Expression expected, Expression actual) {
     assertThat(expected).isInstanceOf(UnboundPredicate.class);
     assertEquals((UnboundPredicate<?>) expected, (UnboundPredicate<?>) actual);