Skip to content

Commit a3e8f37

Browse files
committed
Steven's comment
1 parent eeb9191 commit a3e8f37

1 file changed

Lines changed: 18 additions & 18 deletions

File tree

parquet/src/main/java/org/apache/iceberg/parquet/ParquetFormatModel.java

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -222,17 +222,17 @@ public FileAppender<D> build() throws IOException {
222222
private static class ReadBuilderWrapper<R, D, S> implements ReadBuilder<D, S> {
223223
private final Parquet.ReadBuilder internal;
224224
private final ReaderFunction<R, S, MessageType> readerFunction;
225-
private final boolean batchReader;
225+
private final boolean isBatchReader;
226226
private S engineSchema;
227227
private Map<Integer, ?> idToConstant = ImmutableMap.of();
228228

229229
private ReadBuilderWrapper(
230230
InputFile inputFile,
231231
ReaderFunction<R, S, MessageType> readerFunction,
232-
boolean batchReader) {
232+
boolean isBatchReader) {
233233
this.internal = Parquet.read(inputFile);
234234
this.readerFunction = readerFunction;
235-
this.batchReader = batchReader;
235+
this.isBatchReader = isBatchReader;
236236
}
237237

238238
@Override
@@ -297,21 +297,21 @@ public ReadBuilder<D, S> withNameMapping(NameMapping nameMapping) {
297297

298298
@Override
299299
public CloseableIterable<D> build() {
300-
return batchReader
301-
? internal
302-
.createBatchedReaderFunc(
303-
(icebergSchema, messageType) ->
304-
(VectorizedReader<?>)
305-
readerFunction.read(
306-
icebergSchema, messageType, engineSchema, idToConstant))
307-
.build()
308-
: internal
309-
.createReaderFunc(
310-
(icebergSchema, messageType) ->
311-
(ParquetValueReader<?>)
312-
readerFunction.read(
313-
icebergSchema, messageType, engineSchema, idToConstant))
314-
.build();
300+
if (isBatchReader) {
301+
return internal
302+
.createBatchedReaderFunc(
303+
(icebergSchema, messageType) ->
304+
(VectorizedReader<?>)
305+
readerFunction.read(icebergSchema, messageType, engineSchema, idToConstant))
306+
.build();
307+
} else {
308+
return internal
309+
.createReaderFunc(
310+
(icebergSchema, messageType) ->
311+
(ParquetValueReader<?>)
312+
readerFunction.read(icebergSchema, messageType, engineSchema, idToConstant))
313+
.build();
314+
}
315315
}
316316
}
317317
}

0 commit comments

Comments
 (0)