Check the byte order of input buffers when serializing/deserializing geometry bounds

Author: Kontinuation

api/src/main/java/org/apache/iceberg/geospatial/BoundingBox.java

@@ -51,6 +51,8 @@ public static BoundingBox fromByteBuffers(ByteBuffer min, ByteBuffer max) {
    * @return a BoundingBox instance
    */
   public static BoundingBox fromByteBuffer(ByteBuffer buffer) {
+    Preconditions.checkArgument(
+        buffer.order() == ByteOrder.LITTLE_ENDIAN, "Invalid byte order: big endian");
     ByteBuffer tmp = buffer.duplicate();
     tmp.order(ByteOrder.LITTLE_ENDIAN);
 

api/src/main/java/org/apache/iceberg/geospatial/GeospatialBound.java

@@ -63,6 +63,8 @@ public class GeospatialBound {
    * @throws IllegalArgumentException if the buffer has an invalid size
    */
   public static GeospatialBound fromByteBuffer(ByteBuffer buffer) {
+    Preconditions.checkArgument(
+        buffer.order() == ByteOrder.LITTLE_ENDIAN, "Invalid byte order: big endian");
     ByteBuffer tmp = buffer.duplicate();
     tmp.order(ByteOrder.LITTLE_ENDIAN);
     int size = tmp.remaining();
@@ -146,7 +148,7 @@ public ByteBuffer toByteBuffer() {
    * @throws IllegalArgumentException if the byte array has an invalid length
    */
   public static GeospatialBound fromByteArray(byte[] bytes) {
-    return fromByteBuffer(ByteBuffer.wrap(bytes));
+    return fromByteBuffer(ByteBuffer.wrap(bytes).order(ByteOrder.LITTLE_ENDIAN));
   }
 
   /**

api/src/test/java/org/apache/iceberg/geospatial/TestBoundingBox.java

@@ -104,12 +104,8 @@ public void testFromByteBuffer() {
     GeospatialBound max = GeospatialBound.createXY(3.0, 4.0);
     BoundingBox box = new BoundingBox(min, max);
     ByteBuffer buffer = box.toByteBuffer();
-    for (ByteOrder byteOrder : new ByteOrder[] {ByteOrder.BIG_ENDIAN, ByteOrder.LITTLE_ENDIAN}) {
-      buffer.order(byteOrder);
-      assertThat(BoundingBox.fromByteBuffer(buffer)).isEqualTo(box);
-      assertThat(buffer.position()).isEqualTo(0);
-      assertThat(buffer.order()).isEqualTo(byteOrder);
-    }
+    assertThat(BoundingBox.fromByteBuffer(buffer)).isEqualTo(box);
+    assertThat(buffer.position()).isEqualTo(0);
   }
 
   @Test

api/src/test/java/org/apache/iceberg/geospatial/TestGeospatialBound.java

@@ -213,17 +213,13 @@ public void testFromByteBuffer() {
           0, 0, 0, 0, 0, 0, 36, 64, // 10.0 in little-endian IEEE 754
           0, 0, 0, 0, 0, 0, 42, 64 // 13.0 in little-endian IEEE 754
         };
-    ByteBuffer xyBuffer = ByteBuffer.wrap(xyBytes);
-    for (ByteOrder endianness : new ByteOrder[] {ByteOrder.BIG_ENDIAN, ByteOrder.LITTLE_ENDIAN}) {
-      xyBuffer.order(endianness);
-      GeospatialBound xy = GeospatialBound.fromByteBuffer(xyBuffer);
-      assertThat(xy.x()).isEqualTo(10.0);
-      assertThat(xy.y()).isEqualTo(13.0);
-      assertThat(xy.hasZ()).isFalse();
-      assertThat(xy.hasM()).isFalse();
-      assertThat(xyBuffer.position()).isEqualTo(0);
-      assertThat(xyBuffer.order()).isEqualTo(endianness);
-    }
+    ByteBuffer xyBuffer = ByteBuffer.wrap(xyBytes).order(ByteOrder.LITTLE_ENDIAN);
+    GeospatialBound xy = GeospatialBound.fromByteBuffer(xyBuffer);
+    assertThat(xy.x()).isEqualTo(10.0);
+    assertThat(xy.y()).isEqualTo(13.0);
+    assertThat(xy.hasZ()).isFalse();
+    assertThat(xy.hasM()).isFalse();
+    assertThat(xyBuffer.position()).isEqualTo(0);
   }
 
   private GeospatialBound roundTripSerDe(GeospatialBound original) {