FINERACT-2538: Fix String Locale compiler warning in EnumValueValidator

hms2186 · hms2186 · commit cb640eaa7ad1 · 2026-03-16T19:52:42.000+05:30
diff --git a/fineract-core/src/main/java/org/apache/fineract/portfolio/calendar/domain/Calendar.java b/fineract-core/src/main/java/org/apache/fineract/portfolio/calendar/domain/Calendar.java
@@ -518,7 +518,7 @@ private static String constructRecurrence(final CalendarFrequencyType frequencyT
         final StringBuilder recurrenceBuilder = new StringBuilder(200);
 
         recurrenceBuilder.append("FREQ=");
-        recurrenceBuilder.append(frequencyType.toString().toUpperCase());
+        recurrenceBuilder.append(frequencyType.toString().toUpperCase(java.util.Locale.ROOT));
         if (interval > 1) {
             recurrenceBuilder.append(";INTERVAL=");
             recurrenceBuilder.append(interval);
@@ -528,7 +528,7 @@ private static String constructRecurrence(final CalendarFrequencyType frequencyT
                 final CalendarWeekDaysType weekDays = CalendarWeekDaysType.fromInt(repeatsOnDay);
                 if (!weekDays.isInvalid()) {
                     recurrenceBuilder.append(";BYDAY=");
-                    recurrenceBuilder.append(weekDays.toString().toUpperCase());
+                    recurrenceBuilder.append(weekDays.toString().toUpperCase(java.util.Locale.ROOT));
                 }
             }
         }
@@ -548,7 +548,7 @@ private static String constructRecurrence(final CalendarFrequencyType frequencyT
                 final CalendarWeekDaysType weekday = CalendarWeekDaysType.fromInt(repeatsOnDay);
                 if (!weekday.isInvalid()) {
                     recurrenceBuilder.append(";BYDAY=");
-                    recurrenceBuilder.append(weekday.toString().toUpperCase());
+                    recurrenceBuilder.append(weekday.toString().toUpperCase(java.util.Locale.ROOT));
                 }
             }
         }
diff --git a/fineract-core/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java b/fineract-core/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java
@@ -299,10 +299,10 @@ public static String getRRuleReadable(final LocalDate startDate, final String re
                 NthDayNameEnum nthDayName = NthDayNameEnum.from(nthDayType.toString());
                 DayNameEnum weekdayType = DayNameEnum.from(weekDay.getDay().name());
                 if (recur.getInterval() == 1 || recur.getInterval() == -1) {
-                    humanReadable = "Monthly on " + nthDayName.getCode().toLowerCase() + " " + weekdayType.getCode().toLowerCase();
+                    humanReadable = "Monthly on " + nthDayName.getCode().toLowerCase(java.util.Locale.ROOT) + " " + weekdayType.getCode().toLowerCase(java.util.Locale.ROOT);
                 } else {
-                    humanReadable = "Every " + recur.getInterval() + " months on " + nthDayName.getCode().toLowerCase() + " "
-                            + weekdayType.getCode().toLowerCase();
+                    humanReadable = "Every " + recur.getInterval() + " months on " + nthDayName.getCode().toLowerCase(java.util.Locale.ROOT) + " "
+                            + weekdayType.getCode().toLowerCase(java.util.Locale.ROOT);
                 }
             } else if (monthDay != null) {
                 if (monthDay == -1) {
@@ -756,7 +756,7 @@ public static void validateNthDayOfMonthFrequency(DataValidatorBuilder baseDataV
             if (nthDayType == NthDayType.ONE || nthDayType == NthDayType.TWO || nthDayType == NthDayType.THREE
                     || nthDayType == NthDayType.FOUR) {
                 baseDataValidator.reset().parameter(repeatsOnDayParamName).value(repeatsOnDay).cantBeBlankWhenParameterProvidedIs(
-                        repeatsOnNthDayOfMonthParamName, NthDayNameEnum.from(nthDayType.toString()).getCode().toLowerCase());
+                        repeatsOnNthDayOfMonthParamName, NthDayNameEnum.from(nthDayType.toString()).getCode().toLowerCase(java.util.Locale.ROOT));
             }
         }
     }
diff --git a/fineract-core/src/main/java/org/apache/fineract/useradministration/domain/AppUser.java b/fineract-core/src/main/java/org/apache/fineract/useradministration/domain/AppUser.java
@@ -531,8 +531,8 @@ public void validateHasDeletePermission(final String resourceType) {
     }
 
     private void validateHasPermission(final String prefix, final String resourceType) {
-        final String authorizationMessage = "User has no authority to " + prefix + " " + resourceType.toLowerCase() + "s";
-        final String matchPermission = prefix + "_" + resourceType.toUpperCase();
+        final String authorizationMessage = "User has no authority to " + prefix + " " + resourceType.toLowerCase(java.util.Locale.ROOT) + "s";
+        final String matchPermission = prefix + "_" + resourceType.toUpperCase(java.util.Locale.ROOT);
 
         if (!hasNotPermissionForAnyOf("ALL_FUNCTIONS", "ALL_FUNCTIONS_READ", matchPermission)) {
             return;
@@ -615,7 +615,7 @@ public void validateHasReadPermission(final String function, final Long userId)
     }
 
     public void validateHasCheckerPermissionTo(final String function) {
-        final String checkerPermissionName = function.toUpperCase() + "_CHECKER";
+        final String checkerPermissionName = function.toUpperCase(java.util.Locale.ROOT) + "_CHECKER";
         if (hasNotPermissionTo("CHECKER_SUPER_USER") && hasNotPermissionTo(checkerPermissionName)) {
             final String authorizationMessage = "User has no authority to be a checker for: " + function;
             throw new NoAuthorizationException(authorizationMessage);
diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaign.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaign.java
@@ -523,7 +523,7 @@ private static String constructRecurrence(final CalendarFrequencyType frequencyT
         final StringBuilder recurrenceBuilder = new StringBuilder(200);
 
         recurrenceBuilder.append("FREQ=");
-        recurrenceBuilder.append(frequencyType.toString().toUpperCase());
+        recurrenceBuilder.append(frequencyType.toString().toUpperCase(java.util.Locale.ROOT));
         if (interval > 1) {
             recurrenceBuilder.append(";INTERVAL=");
             recurrenceBuilder.append(interval);
@@ -533,7 +533,7 @@ private static String constructRecurrence(final CalendarFrequencyType frequencyT
                 final CalendarWeekDaysType weekDays = CalendarWeekDaysType.fromInt(repeatsOnDay);
                 if (!weekDays.isInvalid()) {
                     recurrenceBuilder.append(";BYDAY=");
-                    recurrenceBuilder.append(weekDays.toString().toUpperCase());
+                    recurrenceBuilder.append(weekDays.toString().toUpperCase(java.util.Locale.ROOT));
                 }
             }
         }
diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/note/service/NoteWritePlatformServiceJpaRepositoryImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/note/service/NoteWritePlatformServiceJpaRepositoryImpl.java
@@ -250,7 +250,7 @@ private CommandProcessingResult updateClientNote(final JsonCommand command) {
 
         final Note noteForUpdate = this.noteRepository.findByClientAndId(client, noteId);
         if (noteForUpdate == null) {
-            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());
+            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));
         }
 
         final Map<String, Object> changes = noteForUpdate.update(command);
@@ -280,7 +280,7 @@ private CommandProcessingResult updateGroupNote(final JsonCommand command) {
         final Note noteForUpdate = this.noteRepository.findByGroupAndId(group, noteId);
 
         if (noteForUpdate == null) {
-            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());
+            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));
         }
 
         final Map<String, Object> changes = noteForUpdate.update(command);
@@ -307,7 +307,7 @@ private CommandProcessingResult updateLoanNote(final JsonCommand command) {
         final Loan loan = this.loanRepository.findOneWithNotFoundDetection(resourceId);
         final Note noteForUpdate = this.noteRepository.findByLoanAndId(loan, noteId);
         if (noteForUpdate == null) {
-            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());
+            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));
         }
 
         final Map<String, Object> changes = noteForUpdate.update(command);
@@ -334,7 +334,7 @@ private CommandProcessingResult updateLoanTransactionNote(final JsonCommand comm
         final Note noteForUpdate = this.noteRepository.findByLoanTransactionAndId(loanTransaction, noteId);
 
         if (noteForUpdate == null) {
-            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());
+            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));
         }
 
         final Map<String, Object> changes = noteForUpdate.update(command);
@@ -356,7 +356,7 @@ private CommandProcessingResult updateSavingAccountNote(final JsonCommand comman
 
         final Note noteForUpdate = this.noteRepository.findBySavingsAccountAndId(savingAccount, noteId);
         if (noteForUpdate == null) {
-            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());
+            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));
         }
         final Map<String, Object> changes = noteForUpdate.update(command);
         if (!changes.isEmpty()) {
@@ -463,7 +463,7 @@ private Note getNoteForDelete(final JsonCommand command) {
             break;
         }
         if (noteForUpdate == null) {
-            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());
+            throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));
         }
         return noteForUpdate;
     }
diff --git a/fineract-validation/src/main/java/org/apache/fineract/validation/constraints/EnumValueValidator.java b/fineract-validation/src/main/java/org/apache/fineract/validation/constraints/EnumValueValidator.java
@@ -30,12 +30,12 @@ public class EnumValueValidator implements ConstraintValidator<EnumValue, String
 
     @Override
     public void initialize(EnumValue annotation) {
-        acceptedValues = Arrays.stream(annotation.enumClass().getEnumConstants()).map(e -> e.name().toLowerCase())
+        acceptedValues = Arrays.stream(annotation.enumClass().getEnumConstants()).map(e -> e.name().toLowerCase(java.util.Locale.ROOT))
                 .collect(Collectors.toSet());
     }
 
     @Override
     public boolean isValid(String value, ConstraintValidatorContext context) {
-        return value != null && acceptedValues.contains(value.toLowerCase());
+        return value != null && acceptedValues.contains(value.toLowerCase(java.util.Locale.ROOT));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -518,7 +518,7 @@ private static String constructRecurrence(final CalendarFrequencyType frequencyT`
`518`	`518`	`final StringBuilder recurrenceBuilder = new StringBuilder(200);`
`519`	`519`
`520`	`520`	`recurrenceBuilder.append("FREQ=");`
`521`		`- recurrenceBuilder.append(frequencyType.toString().toUpperCase());`
	`521`	`+ recurrenceBuilder.append(frequencyType.toString().toUpperCase(java.util.Locale.ROOT));`
`522`	`522`	`if (interval > 1) {`
`523`	`523`	`recurrenceBuilder.append(";INTERVAL=");`
`524`	`524`	`recurrenceBuilder.append(interval);`
`@@ -528,7 +528,7 @@ private static String constructRecurrence(final CalendarFrequencyType frequencyT`
`528`	`528`	`final CalendarWeekDaysType weekDays = CalendarWeekDaysType.fromInt(repeatsOnDay);`
`529`	`529`	`if (!weekDays.isInvalid()) {`
`530`	`530`	`recurrenceBuilder.append(";BYDAY=");`
`531`		`- recurrenceBuilder.append(weekDays.toString().toUpperCase());`
	`531`	`+ recurrenceBuilder.append(weekDays.toString().toUpperCase(java.util.Locale.ROOT));`
`532`	`532`	`}`
`533`	`533`	`}`
`534`	`534`	`}`
`@@ -548,7 +548,7 @@ private static String constructRecurrence(final CalendarFrequencyType frequencyT`
`548`	`548`	`final CalendarWeekDaysType weekday = CalendarWeekDaysType.fromInt(repeatsOnDay);`
`549`	`549`	`if (!weekday.isInvalid()) {`
`550`	`550`	`recurrenceBuilder.append(";BYDAY=");`
`551`		`- recurrenceBuilder.append(weekday.toString().toUpperCase());`
	`551`	`+ recurrenceBuilder.append(weekday.toString().toUpperCase(java.util.Locale.ROOT));`
`552`	`552`	`}`
`553`	`553`	`}`
`554`	`554`	`}`
Original file line number	Diff line number	Diff line change
`@@ -299,10 +299,10 @@ public static String getRRuleReadable(final LocalDate startDate, final String re`
`299`	`299`	`NthDayNameEnum nthDayName = NthDayNameEnum.from(nthDayType.toString());`
`300`	`300`	`DayNameEnum weekdayType = DayNameEnum.from(weekDay.getDay().name());`
`301`	`301`	`if (recur.getInterval() == 1 \|\| recur.getInterval() == -1) {`
`302`		`- humanReadable = "Monthly on " + nthDayName.getCode().toLowerCase() + " " + weekdayType.getCode().toLowerCase();`
	`302`	`+ humanReadable = "Monthly on " + nthDayName.getCode().toLowerCase(java.util.Locale.ROOT) + " " + weekdayType.getCode().toLowerCase(java.util.Locale.ROOT);`
`303`	`303`	`} else {`
`304`		`- humanReadable = "Every " + recur.getInterval() + " months on " + nthDayName.getCode().toLowerCase() + " "`
`305`		`- + weekdayType.getCode().toLowerCase();`
	`304`	`+ humanReadable = "Every " + recur.getInterval() + " months on " + nthDayName.getCode().toLowerCase(java.util.Locale.ROOT) + " "`
	`305`	`+ + weekdayType.getCode().toLowerCase(java.util.Locale.ROOT);`
`306`	`306`	`}`
`307`	`307`	`} else if (monthDay != null) {`
`308`	`308`	`if (monthDay == -1) {`
`@@ -756,7 +756,7 @@ public static void validateNthDayOfMonthFrequency(DataValidatorBuilder baseDataV`
`756`	`756`	`if (nthDayType == NthDayType.ONE \|\| nthDayType == NthDayType.TWO \|\| nthDayType == NthDayType.THREE`
`757`	`757`	`\|\| nthDayType == NthDayType.FOUR) {`
`758`	`758`	`baseDataValidator.reset().parameter(repeatsOnDayParamName).value(repeatsOnDay).cantBeBlankWhenParameterProvidedIs(`
`759`		`- repeatsOnNthDayOfMonthParamName, NthDayNameEnum.from(nthDayType.toString()).getCode().toLowerCase());`
	`759`	`+ repeatsOnNthDayOfMonthParamName, NthDayNameEnum.from(nthDayType.toString()).getCode().toLowerCase(java.util.Locale.ROOT));`
`760`	`760`	`}`
`761`	`761`	`}`
`762`	`762`	`}`
Original file line number	Diff line number	Diff line change
`@@ -523,7 +523,7 @@ private static String constructRecurrence(final CalendarFrequencyType frequencyT`
`523`	`523`	`final StringBuilder recurrenceBuilder = new StringBuilder(200);`
`524`	`524`
`525`	`525`	`recurrenceBuilder.append("FREQ=");`
`526`		`- recurrenceBuilder.append(frequencyType.toString().toUpperCase());`
	`526`	`+ recurrenceBuilder.append(frequencyType.toString().toUpperCase(java.util.Locale.ROOT));`
`527`	`527`	`if (interval > 1) {`
`528`	`528`	`recurrenceBuilder.append(";INTERVAL=");`
`529`	`529`	`recurrenceBuilder.append(interval);`
`@@ -533,7 +533,7 @@ private static String constructRecurrence(final CalendarFrequencyType frequencyT`
`533`	`533`	`final CalendarWeekDaysType weekDays = CalendarWeekDaysType.fromInt(repeatsOnDay);`
`534`	`534`	`if (!weekDays.isInvalid()) {`
`535`	`535`	`recurrenceBuilder.append(";BYDAY=");`
`536`		`- recurrenceBuilder.append(weekDays.toString().toUpperCase());`
	`536`	`+ recurrenceBuilder.append(weekDays.toString().toUpperCase(java.util.Locale.ROOT));`
`537`	`537`	`}`
`538`	`538`	`}`
`539`	`539`	`}`
Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ private CommandProcessingResult updateClientNote(final JsonCommand command) {`
`250`	`250`
`251`	`251`	`final Note noteForUpdate = this.noteRepository.findByClientAndId(client, noteId);`
`252`	`252`	`if (noteForUpdate == null) {`
`253`		`- throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());`
	`253`	`+ throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));`
`254`	`254`	`}`
`255`	`255`
`256`	`256`	`final Map<String, Object> changes = noteForUpdate.update(command);`
`@@ -280,7 +280,7 @@ private CommandProcessingResult updateGroupNote(final JsonCommand command) {`
`280`	`280`	`final Note noteForUpdate = this.noteRepository.findByGroupAndId(group, noteId);`
`281`	`281`
`282`	`282`	`if (noteForUpdate == null) {`
`283`		`- throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());`
	`283`	`+ throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`final Map<String, Object> changes = noteForUpdate.update(command);`
`@@ -307,7 +307,7 @@ private CommandProcessingResult updateLoanNote(final JsonCommand command) {`
`307`	`307`	`final Loan loan = this.loanRepository.findOneWithNotFoundDetection(resourceId);`
`308`	`308`	`final Note noteForUpdate = this.noteRepository.findByLoanAndId(loan, noteId);`
`309`	`309`	`if (noteForUpdate == null) {`
`310`		`- throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());`
	`310`	`+ throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));`
`311`	`311`	`}`
`312`	`312`
`313`	`313`	`final Map<String, Object> changes = noteForUpdate.update(command);`
`@@ -334,7 +334,7 @@ private CommandProcessingResult updateLoanTransactionNote(final JsonCommand comm`
`334`	`334`	`final Note noteForUpdate = this.noteRepository.findByLoanTransactionAndId(loanTransaction, noteId);`
`335`	`335`
`336`	`336`	`if (noteForUpdate == null) {`
`337`		`- throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());`
	`337`	`+ throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));`
`338`	`338`	`}`
`339`	`339`
`340`	`340`	`final Map<String, Object> changes = noteForUpdate.update(command);`
`@@ -356,7 +356,7 @@ private CommandProcessingResult updateSavingAccountNote(final JsonCommand comman`
`356`	`356`
`357`	`357`	`final Note noteForUpdate = this.noteRepository.findBySavingsAccountAndId(savingAccount, noteId);`
`358`	`358`	`if (noteForUpdate == null) {`
`359`		`- throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());`
	`359`	`+ throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));`
`360`	`360`	`}`
`361`	`361`	`final Map<String, Object> changes = noteForUpdate.update(command);`
`362`	`362`	`if (!changes.isEmpty()) {`
`@@ -463,7 +463,7 @@ private Note getNoteForDelete(final JsonCommand command) {`
`463`	`463`	`break;`
`464`	`464`	`}`
`465`	`465`	`if (noteForUpdate == null) {`
`466`		`- throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase());`
	`466`	`+ throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase(java.util.Locale.ROOT));`
`467`	`467`	`}`
`468`	`468`	`return noteForUpdate;`
`469`	`469`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,12 +30,12 @@ public class EnumValueValidator implements ConstraintValidator<EnumValue, String`
`30`	`30`
`31`	`31`	`@Override`
`32`	`32`	`public void initialize(EnumValue annotation) {`
`33`		`- acceptedValues = Arrays.stream(annotation.enumClass().getEnumConstants()).map(e -> e.name().toLowerCase())`
	`33`	`+ acceptedValues = Arrays.stream(annotation.enumClass().getEnumConstants()).map(e -> e.name().toLowerCase(java.util.Locale.ROOT))`
`34`	`34`	`.collect(Collectors.toSet());`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`@Override`
`38`	`38`	`public boolean isValid(String value, ConstraintValidatorContext context) {`
`39`		`- return value != null && acceptedValues.contains(value.toLowerCase());`
	`39`	`+ return value != null && acceptedValues.contains(value.toLowerCase(java.util.Locale.ROOT));`
`40`	`40`	`}`
`41`	`41`	`}`