From b94bde4add8cdc7649b1dc5c35a4d93a06d1d06e Mon Sep 17 00:00:00 2001 From: Alex Smolya Date: Mon, 17 Aug 2026 22:42:46 +0200 Subject: [PATCH 1/4] feat: add ZonedDateTime converters --- .../converters/DefaultConverterLoader.java | 8 ++ .../ZonedDateTimeDateConverter.java | 57 ++++++++++ .../ZonedDateTimeNumberConverter.java | 73 +++++++++++++ .../ZonedDateTimeStringConverter.java | 77 +++++++++++++ .../converter/ZonedDateTimeConverterTest.java | 102 ++++++++++++++++++ 5 files changed, 317 insertions(+) create mode 100644 fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeDateConverter.java create mode 100644 fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeNumberConverter.java create mode 100644 fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java create mode 100644 fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java diff --git a/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/DefaultConverterLoader.java b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/DefaultConverterLoader.java index 88b90d955..50dcec396 100644 --- a/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/DefaultConverterLoader.java +++ b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/DefaultConverterLoader.java @@ -75,6 +75,9 @@ import org.apache.fesod.sheet.converters.string.StringNumberConverter; import org.apache.fesod.sheet.converters.string.StringStringConverter; import org.apache.fesod.sheet.converters.url.UrlImageConverter; +import org.apache.fesod.sheet.converters.zoneddatetime.ZonedDateTimeDateConverter; +import org.apache.fesod.sheet.converters.zoneddatetime.ZonedDateTimeNumberConverter; +import org.apache.fesod.sheet.converters.zoneddatetime.ZonedDateTimeStringConverter; /** * Load default handler @@ -117,6 +120,9 @@ private static void initAllConverter() { putAllConverter(new LocalDateTimeNumberConverter()); putAllConverter(new LocalDateTimeStringConverter()); + putAllConverter(new ZonedDateTimeNumberConverter()); + putAllConverter(new ZonedDateTimeStringConverter()); + putAllConverter(new DoubleBooleanConverter()); putAllConverter(new DoubleNumberConverter()); putAllConverter(new DoubleStringConverter()); @@ -153,6 +159,7 @@ private static void initDefaultWriteConverter() { putWriteConverter(new DateDateConverter()); putWriteConverter(new LocalDateTimeDateConverter()); putWriteConverter(new LocalDateDateConverter()); + putWriteConverter(new ZonedDateTimeDateConverter()); putWriteConverter(new DoubleNumberConverter()); putWriteConverter(new FloatNumberConverter()); putWriteConverter(new IntegerNumberConverter()); @@ -173,6 +180,7 @@ private static void initDefaultWriteConverter() { putWriteStringConverter(new DateStringConverter()); putWriteStringConverter(new LocalDateStringConverter()); putWriteStringConverter(new LocalDateTimeStringConverter()); + putWriteStringConverter(new ZonedDateTimeStringConverter()); putWriteStringConverter(new DoubleStringConverter()); putWriteStringConverter(new FloatStringConverter()); putWriteStringConverter(new IntegerStringConverter()); diff --git a/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeDateConverter.java b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeDateConverter.java new file mode 100644 index 000000000..cc6d851c8 --- /dev/null +++ b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeDateConverter.java @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * This file is part of the Apache Fesod (Incubating) project, which was derived from Alibaba EasyExcel. + * + * Copyright (C) 2018-2024 Alibaba Group Holding Ltd. + */ + +package org.apache.fesod.sheet.converters.zoneddatetime; + +import java.time.LocalDateTime; +import java.time.ZonedDateTime; +import org.apache.fesod.sheet.converters.Converter; +import org.apache.fesod.sheet.metadata.GlobalConfiguration; +import org.apache.fesod.sheet.metadata.data.WriteCellData; +import org.apache.fesod.sheet.metadata.property.ExcelContentProperty; +import org.apache.fesod.sheet.util.DateUtils; +import org.apache.fesod.sheet.util.WorkBookUtil; + +/** ZonedDateTime and date converter. */ +public class ZonedDateTimeDateConverter implements Converter { + @Override + public Class supportJavaTypeKey() { + return ZonedDateTime.class; + } + + @Override + public WriteCellData convertToExcelData( + ZonedDateTime value, ExcelContentProperty contentProperty, GlobalConfiguration globalConfiguration) + throws Exception { + LocalDateTime localDateTime = value.toLocalDateTime(); + WriteCellData cellData = new WriteCellData<>(localDateTime); + String format = null; + if (contentProperty != null && contentProperty.getDateTimeFormatProperty() != null) { + format = contentProperty.getDateTimeFormatProperty().getFormat(); + } + WorkBookUtil.fillDataFormat(cellData, format, DateUtils.defaultDateFormat); + return cellData; + } +} diff --git a/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeNumberConverter.java b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeNumberConverter.java new file mode 100644 index 000000000..ed602ff4b --- /dev/null +++ b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeNumberConverter.java @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * This file is part of the Apache Fesod (Incubating) project, which was derived from Alibaba EasyExcel. + * + * Copyright (C) 2018-2024 Alibaba Group Holding Ltd. + */ + +package org.apache.fesod.sheet.converters.zoneddatetime; + +import java.math.BigDecimal; +import java.time.ZoneId; +import java.time.ZonedDateTime; +import org.apache.fesod.sheet.converters.Converter; +import org.apache.fesod.sheet.enums.CellDataTypeEnum; +import org.apache.fesod.sheet.metadata.GlobalConfiguration; +import org.apache.fesod.sheet.metadata.data.ReadCellData; +import org.apache.fesod.sheet.metadata.data.WriteCellData; +import org.apache.fesod.sheet.metadata.property.ExcelContentProperty; +import org.apache.fesod.sheet.util.DateUtils; +import org.apache.poi.ss.usermodel.DateUtil; + +/** ZonedDateTime and number converter. */ +public class ZonedDateTimeNumberConverter implements Converter { + @Override + public Class supportJavaTypeKey() { + return ZonedDateTime.class; + } + + @Override + public CellDataTypeEnum supportExcelTypeKey() { + return CellDataTypeEnum.NUMBER; + } + + @Override + public ZonedDateTime convertToJavaData( + ReadCellData cellData, ExcelContentProperty contentProperty, GlobalConfiguration globalConfiguration) { + boolean use1904windowing = globalConfiguration.getUse1904windowing(); + if (contentProperty != null && contentProperty.getDateTimeFormatProperty() != null) { + use1904windowing = contentProperty.getDateTimeFormatProperty().getUse1904windowing(); + } + return DateUtils.getLocalDateTime(cellData.getNumberValue().doubleValue(), use1904windowing) + .atZone(ZoneId.systemDefault()); + } + + @Override + public WriteCellData convertToExcelData( + ZonedDateTime value, ExcelContentProperty contentProperty, GlobalConfiguration globalConfiguration) { + boolean use1904windowing = globalConfiguration.getUse1904windowing(); + if (contentProperty != null && contentProperty.getDateTimeFormatProperty() != null) { + use1904windowing = contentProperty.getDateTimeFormatProperty().getUse1904windowing(); + } + return new WriteCellData<>( + BigDecimal.valueOf(DateUtil.getExcelDate(value.toLocalDateTime(), use1904windowing))); + } +} diff --git a/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java new file mode 100644 index 000000000..678c99f5e --- /dev/null +++ b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * This file is part of the Apache Fesod (Incubating) project, which was derived from Alibaba EasyExcel. + * + * Copyright (C) 2018-2024 Alibaba Group Holding Ltd. + */ + +package org.apache.fesod.sheet.converters.zoneddatetime; + +import java.time.LocalDateTime; +import java.time.ZoneId; +import java.time.ZonedDateTime; +import java.time.format.DateTimeFormatter; +import java.time.format.DateTimeParseException; +import java.util.Locale; +import org.apache.fesod.sheet.converters.Converter; +import org.apache.fesod.sheet.enums.CellDataTypeEnum; +import org.apache.fesod.sheet.metadata.GlobalConfiguration; +import org.apache.fesod.sheet.metadata.data.ReadCellData; +import org.apache.fesod.sheet.metadata.data.WriteCellData; +import org.apache.fesod.sheet.metadata.property.ExcelContentProperty; + +/** ZonedDateTime and string converter. */ +public class ZonedDateTimeStringConverter implements Converter { + @Override + public Class supportJavaTypeKey() { + return ZonedDateTime.class; + } + + @Override + public CellDataTypeEnum supportExcelTypeKey() { + return CellDataTypeEnum.STRING; + } + + @Override + public ZonedDateTime convertToJavaData( + ReadCellData cellData, ExcelContentProperty contentProperty, GlobalConfiguration globalConfiguration) { + DateTimeFormatter formatter = formatter(contentProperty, globalConfiguration.getLocale()); + try { + return ZonedDateTime.parse(cellData.getStringValue(), formatter); + } catch (DateTimeParseException e) { + return LocalDateTime.parse(cellData.getStringValue(), formatter).atZone(ZoneId.systemDefault()); + } + } + + @Override + public WriteCellData convertToExcelData( + ZonedDateTime value, ExcelContentProperty contentProperty, GlobalConfiguration globalConfiguration) { + return new WriteCellData<>(value.format(formatter(contentProperty, globalConfiguration.getLocale()))); + } + + private DateTimeFormatter formatter(ExcelContentProperty contentProperty, Locale locale) { + if (contentProperty == null || contentProperty.getDateTimeFormatProperty() == null) { + return DateTimeFormatter.ISO_ZONED_DATE_TIME; + } + return DateTimeFormatter.ofPattern( + contentProperty.getDateTimeFormatProperty().getFormat(), locale); + } +} diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java new file mode 100644 index 000000000..de9a01da7 --- /dev/null +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * This file is part of the Apache Fesod (Incubating) project, which was derived from Alibaba EasyExcel. + * + * Copyright (C) 2018-2024 Alibaba Group Holding Ltd. + */ + +package org.apache.fesod.sheet.converter; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import java.time.ZoneId; +import java.time.ZonedDateTime; +import org.apache.fesod.sheet.converters.ConverterKeyBuild; +import org.apache.fesod.sheet.converters.DefaultConverterLoader; +import org.apache.fesod.sheet.converters.zoneddatetime.ZonedDateTimeDateConverter; +import org.apache.fesod.sheet.converters.zoneddatetime.ZonedDateTimeNumberConverter; +import org.apache.fesod.sheet.converters.zoneddatetime.ZonedDateTimeStringConverter; +import org.apache.fesod.sheet.enums.CellDataTypeEnum; +import org.apache.fesod.sheet.metadata.GlobalConfiguration; +import org.apache.fesod.sheet.metadata.data.ReadCellData; +import org.apache.fesod.sheet.metadata.data.WriteCellData; +import org.apache.fesod.sheet.metadata.property.DateTimeFormatProperty; +import org.apache.fesod.sheet.metadata.property.ExcelContentProperty; +import org.junit.jupiter.api.Test; + +class ZonedDateTimeConverterTest { + private static final ZonedDateTime VALUE = ZonedDateTime.of(2020, 1, 2, 3, 4, 5, 0, ZoneId.of("UTC")); + + @Test + void dateConverterDropsZoneWhilePreservingLocalDateTime() throws Exception { + WriteCellData result = + new ZonedDateTimeDateConverter().convertToExcelData(VALUE, null, new GlobalConfiguration()); + assertEquals(CellDataTypeEnum.DATE, result.getType()); + assertEquals(VALUE.toLocalDateTime(), result.getDateValue()); + } + + @Test + void numberConverterDropsZoneWhilePreservingLocalDateTime() { + ZonedDateTimeNumberConverter converter = new ZonedDateTimeNumberConverter(); + GlobalConfiguration globalConfiguration = new GlobalConfiguration(); + WriteCellData written = converter.convertToExcelData(VALUE, null, globalConfiguration); + ZonedDateTime read = + converter.convertToJavaData(new ReadCellData<>(written.getNumberValue()), null, globalConfiguration); + assertEquals(VALUE.toLocalDateTime(), read.toLocalDateTime()); + assertEquals(ZoneId.systemDefault(), read.getZone()); + } + + @Test + void stringConverterPreservesZoneInIsoText() throws Exception { + ZonedDateTimeStringConverter converter = new ZonedDateTimeStringConverter(); + GlobalConfiguration globalConfiguration = new GlobalConfiguration(); + WriteCellData written = converter.convertToExcelData(VALUE, null, globalConfiguration); + assertEquals( + VALUE, + converter.convertToJavaData(new ReadCellData<>(written.getStringValue()), null, globalConfiguration)); + } + + @Test + void stringConverterUsesConfiguredPattern() throws Exception { + ZonedDateTimeStringConverter converter = new ZonedDateTimeStringConverter(); + ExcelContentProperty property = new ExcelContentProperty(); + property.setDateTimeFormatProperty(new DateTimeFormatProperty("yyyy-MM-dd HH:mm:ss Z", false)); + GlobalConfiguration globalConfiguration = new GlobalConfiguration(); + assertEquals( + "2020-01-02 03:04:05 +0000", + converter + .convertToExcelData(VALUE, property, globalConfiguration) + .getStringValue()); + } + + @Test + void convertersAreRegisteredForSupportedDirections() { + assertEquals( + ZonedDateTimeDateConverter.class, + DefaultConverterLoader.loadDefaultWriteConverter() + .get(ConverterKeyBuild.buildKey(ZonedDateTime.class)) + .getClass()); + assertEquals( + 2, + DefaultConverterLoader.loadAllConverter().entrySet().stream() + .filter(entry -> entry.getKey().getClazz() == ZonedDateTime.class) + .count()); + } +} From 387a8852073ec41944baa0ee692379cd838e5f91 Mon Sep 17 00:00:00 2001 From: Alex Smolya Date: Wed, 19 Aug 2026 19:54:32 +0200 Subject: [PATCH 2/4] fix(converter): tag ZonedDateTimeConverterTest with UNIT and handle empty format pattern - Add @Tag(Tags.UNIT) to ZonedDateTimeConverterTest following repository conventions - Handle empty or null format strings in ZonedDateTimeStringConverter by falling back to ISO_ZONED_DATE_TIME - Add regression coverage for empty and null format patterns --- .../ZonedDateTimeStringConverter.java | 5 +++- .../converter/ZonedDateTimeConverterTest.java | 26 +++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java index 678c99f5e..ba3fc6bdd 100644 --- a/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java +++ b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java @@ -31,6 +31,7 @@ import java.time.format.DateTimeFormatter; import java.time.format.DateTimeParseException; import java.util.Locale; +import org.apache.fesod.common.util.StringUtils; import org.apache.fesod.sheet.converters.Converter; import org.apache.fesod.sheet.enums.CellDataTypeEnum; import org.apache.fesod.sheet.metadata.GlobalConfiguration; @@ -68,7 +69,9 @@ public WriteCellData convertToExcelData( } private DateTimeFormatter formatter(ExcelContentProperty contentProperty, Locale locale) { - if (contentProperty == null || contentProperty.getDateTimeFormatProperty() == null) { + if (contentProperty == null + || contentProperty.getDateTimeFormatProperty() == null + || StringUtils.isEmpty(contentProperty.getDateTimeFormatProperty().getFormat())) { return DateTimeFormatter.ISO_ZONED_DATE_TIME; } return DateTimeFormatter.ofPattern( diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java index de9a01da7..0ad877036 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java @@ -39,8 +39,11 @@ import org.apache.fesod.sheet.metadata.data.WriteCellData; import org.apache.fesod.sheet.metadata.property.DateTimeFormatProperty; import org.apache.fesod.sheet.metadata.property.ExcelContentProperty; +import org.apache.fesod.sheet.testkit.Tags; +import org.junit.jupiter.api.Tag; import org.junit.jupiter.api.Test; +@Tag(Tags.UNIT) class ZonedDateTimeConverterTest { private static final ZonedDateTime VALUE = ZonedDateTime.of(2020, 1, 2, 3, 4, 5, 0, ZoneId.of("UTC")); @@ -86,6 +89,29 @@ void stringConverterUsesConfiguredPattern() throws Exception { .getStringValue()); } + @Test + void stringConverterWithEmptyOrNullPatternFallsBackToIso() throws Exception { + ZonedDateTimeStringConverter converter = new ZonedDateTimeStringConverter(); + GlobalConfiguration globalConfiguration = new GlobalConfiguration(); + + ExcelContentProperty emptyProperty = new ExcelContentProperty(); + emptyProperty.setDateTimeFormatProperty(new DateTimeFormatProperty("", false)); + WriteCellData writtenEmpty = converter.convertToExcelData(VALUE, emptyProperty, globalConfiguration); + assertEquals( + VALUE, + converter.convertToJavaData( + new ReadCellData<>(writtenEmpty.getStringValue()), emptyProperty, globalConfiguration)); + + ExcelContentProperty nullFormatProperty = new ExcelContentProperty(); + nullFormatProperty.setDateTimeFormatProperty(new DateTimeFormatProperty(null, false)); + WriteCellData writtenNullFormat = + converter.convertToExcelData(VALUE, nullFormatProperty, globalConfiguration); + assertEquals( + VALUE, + converter.convertToJavaData( + new ReadCellData<>(writtenNullFormat.getStringValue()), nullFormatProperty, globalConfiguration)); + } + @Test void convertersAreRegisteredForSupportedDirections() { assertEquals( From 57408916c90c06aaeb05f4c9fdbfbf88156c0fe1 Mon Sep 17 00:00:00 2001 From: Alex Smolya Date: Wed, 19 Aug 2026 21:43:47 +0200 Subject: [PATCH 3/4] style(converter): apply spotless formatting to ZonedDateTime converter and test --- .../zoneddatetime/ZonedDateTimeStringConverter.java | 3 ++- .../fesod/sheet/converter/ZonedDateTimeConverterTest.java | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java index ba3fc6bdd..ea5e8344b 100644 --- a/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java +++ b/fesod-sheet/src/main/java/org/apache/fesod/sheet/converters/zoneddatetime/ZonedDateTimeStringConverter.java @@ -71,7 +71,8 @@ public WriteCellData convertToExcelData( private DateTimeFormatter formatter(ExcelContentProperty contentProperty, Locale locale) { if (contentProperty == null || contentProperty.getDateTimeFormatProperty() == null - || StringUtils.isEmpty(contentProperty.getDateTimeFormatProperty().getFormat())) { + || StringUtils.isEmpty( + contentProperty.getDateTimeFormatProperty().getFormat())) { return DateTimeFormatter.ISO_ZONED_DATE_TIME; } return DateTimeFormatter.ofPattern( diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java index 0ad877036..cd96412c4 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java @@ -109,7 +109,9 @@ void stringConverterWithEmptyOrNullPatternFallsBackToIso() throws Exception { assertEquals( VALUE, converter.convertToJavaData( - new ReadCellData<>(writtenNullFormat.getStringValue()), nullFormatProperty, globalConfiguration)); + new ReadCellData<>(writtenNullFormat.getStringValue()), + nullFormatProperty, + globalConfiguration)); } @Test From 3de3e40933dca5390ac011f0a36ea78c3a14399e Mon Sep 17 00:00:00 2001 From: Alex Smolya <127655982+alexsmolya@users.noreply.github.com> Date: Thu, 20 Aug 2026 18:30:00 +0200 Subject: [PATCH 4/4] test(converter): add unit tests for use1904windowing in ZonedDateTime converters --- .../converter/ZonedDateTimeConverterTest.java | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java index cd96412c4..0b7362698 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ZonedDateTimeConverterTest.java @@ -26,6 +26,8 @@ package org.apache.fesod.sheet.converter; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotEquals; +import java.math.BigDecimal; import java.time.ZoneId; import java.time.ZonedDateTime; import org.apache.fesod.sheet.converters.ConverterKeyBuild; @@ -40,6 +42,7 @@ import org.apache.fesod.sheet.metadata.property.DateTimeFormatProperty; import org.apache.fesod.sheet.metadata.property.ExcelContentProperty; import org.apache.fesod.sheet.testkit.Tags; +import org.apache.poi.ss.usermodel.DateUtil; import org.junit.jupiter.api.Tag; import org.junit.jupiter.api.Test; @@ -66,6 +69,49 @@ void numberConverterDropsZoneWhilePreservingLocalDateTime() { assertEquals(ZoneId.systemDefault(), read.getZone()); } + @Test + void numberConverterSupports1904Windowing() { + ZonedDateTimeNumberConverter converter = new ZonedDateTimeNumberConverter(); + + // 1. Configured via GlobalConfiguration + GlobalConfiguration global1900 = new GlobalConfiguration(); + GlobalConfiguration global1904 = new GlobalConfiguration(); + global1904.setUse1904windowing(Boolean.TRUE); + + WriteCellData written1900 = converter.convertToExcelData(VALUE, null, global1900); + WriteCellData written1904 = converter.convertToExcelData(VALUE, null, global1904); + + assertEquals( + BigDecimal.valueOf(DateUtil.getExcelDate(VALUE.toLocalDateTime(), false)), + written1900.getNumberValue()); + assertEquals( + BigDecimal.valueOf(DateUtil.getExcelDate(VALUE.toLocalDateTime(), true)), written1904.getNumberValue()); + assertNotEquals(written1900.getNumberValue(), written1904.getNumberValue()); + + ZonedDateTime read1904 = + converter.convertToJavaData(new ReadCellData<>(written1904.getNumberValue()), null, global1904); + assertEquals(VALUE.toLocalDateTime(), read1904.toLocalDateTime()); + assertEquals(ZoneId.systemDefault(), read1904.getZone()); + + ZonedDateTime read1904With1900 = + converter.convertToJavaData(new ReadCellData<>(written1904.getNumberValue()), null, global1900); + assertNotEquals(VALUE.toLocalDateTime(), read1904With1900.toLocalDateTime()); + + // 2. Configured via ExcelContentProperty + ExcelContentProperty property1904 = new ExcelContentProperty(); + property1904.setDateTimeFormatProperty(new DateTimeFormatProperty("yyyy-MM-dd HH:mm:ss", true)); + + WriteCellData writtenProperty1904 = converter.convertToExcelData(VALUE, property1904, global1900); + assertEquals( + BigDecimal.valueOf(DateUtil.getExcelDate(VALUE.toLocalDateTime(), true)), + writtenProperty1904.getNumberValue()); + + ZonedDateTime readProperty1904 = converter.convertToJavaData( + new ReadCellData<>(writtenProperty1904.getNumberValue()), property1904, global1900); + assertEquals(VALUE.toLocalDateTime(), readProperty1904.toLocalDateTime()); + assertEquals(ZoneId.systemDefault(), readProperty1904.getZone()); + } + @Test void stringConverterPreservesZoneInIsoText() throws Exception { ZonedDateTimeStringConverter converter = new ZonedDateTimeStringConverter();