Skip to content

Commit d02c77a

Browse files
committed
JUnit assertThrows Digester153TestCase
1 parent ba2556a commit d02c77a

1 file changed

Lines changed: 12 additions & 5 deletions

File tree

core/src/test/java/org/apache/commons/digester3/Digester153TestCase.java

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,14 @@
2323
import static org.junit.Assert.assertEquals;
2424
import static org.junit.Assert.assertFalse;
2525
import static org.junit.Assert.assertTrue;
26+
import static org.junit.jupiter.api.Assertions.assertThrows;
2627

2728
import org.apache.commons.digester3.annotations.FromAnnotationsRuleModule;
2829
import org.apache.commons.digester3.binder.AbstractRulesModule;
2930
import org.apache.commons.digester3.binder.RulesModule;
3031
import org.apache.commons.digester3.xmlrules.FromXmlRulesModule;
3132
import org.junit.Test;
33+
import org.junit.jupiter.api.function.Executable;
3234
import org.xml.sax.SAXParseException;
3335

3436
/**
@@ -170,17 +172,22 @@ public void basicConstructorWithValuesNotFound()
170172
assertEquals( 0D, bean.getDoubleProperty(), 0 );
171173
}
172174

173-
@Test( expected = SAXParseException.class )
174-
public void basicConstructorWithWrongParameters()
175-
throws Exception
176-
{
175+
@Test
176+
public void basicConstructorWithWrongParameters() {
177177
final ObjectCreateRule createRule = new ObjectCreateRule( TestBean.class );
178178
createRule.setConstructorArgumentTypes( boolean.class );
179179

180180
final Digester digester = new Digester();
181181
digester.addRule( "toplevel/bean", createRule );
182182

183-
digester.parse( getClass().getResourceAsStream( "BasicConstructor.xml" ) );
183+
// FIXME Simplification once upgraded to Java 1.8 and use lambda
184+
final Executable testMethod = new Executable() {
185+
@Override
186+
public void execute() throws Throwable {
187+
digester.parse(getClass().getResourceAsStream("BasicConstructor.xml"));
188+
}
189+
};
190+
assertThrows(SAXParseException.class, testMethod);
184191
}
185192

186193
@Test

0 commit comments

Comments
 (0)