Add source provenance attribute tests

Author: joshua-zivkovic

tests/sources/source_provenance_attributes.py

@@ -20,7 +20,7 @@
 
 from buildstream._testing import generate_project, load_yaml
 from buildstream._testing import cli  # pylint: disable=unused-import
-from buildstream.exceptions import ErrorDomain
+from buildstream.exceptions import ErrorDomain, LoadErrorReason
 
 
 DATA_DIR = os.path.join(os.path.dirname(os.path.realpath(__file__)), "source_provenance_attributes")
@@ -40,6 +40,9 @@ def test_source_provenance_disallow_top_level(cli, datafiles):
     aliases = project_config.get_mapping("aliases")
     aliases["project_dir"] = "file://{}".format(project)
 
+    source_provenance_attrs = project_config.get_mapping("source-provenance-attributes")
+    source_provenance_attrs["homepage"] = "Testing"
+
     generate_project(project, project_config)
 
     # Make sure disallowed usage of top-level source proveance fails
@@ -49,3 +52,108 @@ def test_source_provenance_disallow_top_level(cli, datafiles):
     )
 
     result.assert_main_error(ErrorDomain.SOURCE, "top-level-provenance-on-custom-implementation")
+
+
+@pytest.mark.datafiles(DATA_DIR)
+def test_source_provenance_no_defined_attributes(cli, datafiles):
+    project = str(datafiles)
+
+    # Set the project_dir alias in project.conf to the path to the tested project
+    project_config_path = os.path.join(project, "project.conf")
+    project_config = load_yaml(project_config_path)
+    aliases = project_config.get_mapping("aliases")
+    aliases["project_dir"] = "file://{}".format(project)
+
+    generate_project(project, project_config)
+
+    # Make sure a non-default attribute fails
+    result = cli.run(
+        project=project,
+        args=["show", "--format", "%{source-info}", "target_a.bst"],
+    )
+    result.assert_main_error(ErrorDomain.LOAD, LoadErrorReason.UNDEFINED_SOURCE_PROVENANCE_ATTRIBUTE)
+
+    # Make sure a default attribute fails
+    result = cli.run(
+        project=project,
+        args=["show", "--format", "%{source-info}", "target_b.bst"],
+    )
+    result.assert_main_error(ErrorDomain.LOAD, LoadErrorReason.UNDEFINED_SOURCE_PROVENANCE_ATTRIBUTE)
+
+
+# Test that no defined source provenance attributes blocks all source provenance data
+@pytest.mark.datafiles(DATA_DIR)
+def test_source_provenance_default_attributes(cli, datafiles):
+    project = str(datafiles)
+
+    # Set the project_dir alias in project.conf to the path to the tested project
+    project_config_path = os.path.join(project, "project.conf")
+    project_config = load_yaml(project_config_path)
+    aliases = project_config.get_mapping("aliases")
+    aliases["project_dir"] = "file://{}".format(project)
+
+    # Edit config to fallback to default source provenance attributes
+    project_config.safe_del("source-provenance-attributes")
+
+    generate_project(project, project_config)
+
+    # Make sure defined attributes are available
+    result = cli.run(
+        project=project,
+        args=["show", "--format", "%{source-info}", "target_b.bst"],
+    )
+    result.assert_success()
+
+    provenance_result = ""
+    for line in result.output.split("\n"):
+        if "provenance:" in line or "    " in line:
+            provenance_result += line
+
+    assert provenance_result == "  provenance:    homepage: foo"
+
+    # Make sure undefined attributes fail
+    result = cli.run(
+        project=project,
+        args=["show", "--format", "%{source-info}", "target_a.bst"],
+    )
+    result.assert_main_error(ErrorDomain.LOAD, LoadErrorReason.UNDEFINED_SOURCE_PROVENANCE_ATTRIBUTE)
+
+
+# Test that no defined source provenance attributes blocks all source provenance data
+@pytest.mark.datafiles(DATA_DIR)
+def test_source_provenance_project_defined_attributes(cli, datafiles):
+    project = str(datafiles)
+
+    # Set the project_dir alias in project.conf to the path to the tested project
+    project_config_path = os.path.join(project, "project.conf")
+    project_config = load_yaml(project_config_path)
+    aliases = project_config.get_mapping("aliases")
+    aliases["project_dir"] = "file://{}".format(project)
+
+    # Edit config to only use project specified source provenance attributes
+
+    source_provenance_attrs = project_config.get_mapping("source-provenance-attributes")
+    source_provenance_attrs["originator"] = "Testing"
+
+    generate_project(project, project_config)
+
+    # Make sure defined attributes are available
+    result = cli.run(
+        project=project,
+        args=["show", "--format", "%{source-info}", "target_a.bst"],
+    )
+    result.assert_success()
+
+    provenance_result = ""
+    for line in result.output.split("\n"):
+        if "provenance:" in line or "    " in line:
+            provenance_result += line
+
+    assert provenance_result == "  provenance:    originator: bar"
+
+    # Make sure undefined attributes fail
+    result = cli.run(
+        project=project,
+        args=["show", "--format", "%{source-info}", "target_b.bst"],
+    )
+    result.assert_main_error(ErrorDomain.LOAD, LoadErrorReason.UNDEFINED_SOURCE_PROVENANCE_ATTRIBUTE)

tests/sources/source_provenance_attributes/elements/target_a.bst

@@ -0,0 +1,7 @@
+kind: import
+
+sources:
+- kind: remote
+  url: project_dir:/files/file
+  provenance:
+    originator: bar

tests/sources/source_provenance_attributes/elements/target_b.bst

@@ -0,0 +1,7 @@
+kind: import
+
+sources:
+- kind: remote
+  url: project_dir:/files/file
+  provenance:
+    homepage: foo

tests/sources/source_provenance_attributes/project.conf

@@ -12,3 +12,6 @@ plugins:
   path: plugins
   sources:
   - multisource-plugin
+
+# Don't allow any provenance
+source-provenance-attributes: {}