From 64105c990bd37e94f7b35c3abb80264d6e52fe65 Mon Sep 17 00:00:00 2001 From: Matteo Merli Date: Fri, 10 Jul 2026 07:01:49 -0700 Subject: [PATCH] Skip journal flush-trace loop when debug logging is disabled --- .../org/apache/bookkeeper/bookie/Journal.java | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java index 830763aa022..02ec6f2605a 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java @@ -1151,14 +1151,17 @@ public void run() { journalFlushWatcher.stop().elapsed(TimeUnit.NANOSECONDS), TimeUnit.NANOSECONDS); // Trace the lifetime of entries through persistence - for (QueueEntry e : toFlush) { - if (e != null) { - log.debug() - .attr("ledgerId", e.ledgerId) - .attr("entryId", e.entryId) - .log("Written and queuing for flush"); + RecyclableArrayList flushedEntries = toFlush; + log.debug(e -> { + for (QueueEntry entry : flushedEntries) { + if (entry != null) { + log.debug() + .attr("ledgerId", entry.ledgerId) + .attr("entryId", entry.entryId) + .log("Written and queuing for flush"); + } } - } + }); journalStats.getForceWriteBatchEntriesStats() .registerSuccessfulValue(numEntriesToFlush);