From 5bec62a724395eaee8c9df5795567a7da18d2457 Mon Sep 17 00:00:00 2001 From: Hyukjin Kwon Date: Fri, 23 Jan 2026 10:19:21 +0900 Subject: [PATCH 1/2] Remove obsolete todo --- cpp/src/arrow/compute/kernels/vector_array_sort.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/cpp/src/arrow/compute/kernels/vector_array_sort.cc b/cpp/src/arrow/compute/kernels/vector_array_sort.cc index 950de47733b..4f91fb8c6b6 100644 --- a/cpp/src/arrow/compute/kernels/vector_array_sort.cc +++ b/cpp/src/arrow/compute/kernels/vector_array_sort.cc @@ -183,8 +183,6 @@ class ArrayCompareSorter { const ArraySortOptions& options, ExecContext* ctx) { const auto& dict_array = checked_cast(array); - // TODO: These methods should probably return a const&? They seem capable. - // https://github.com/apache/arrow/issues/35437 auto dict_values = dict_array.dictionary(); auto dict_indices = dict_array.indices(); From 548b56b6b80124ae65f1668c9a4b0993f1341587 Mon Sep 17 00:00:00 2001 From: Hyukjin Kwon Date: Wed, 28 Jan 2026 17:11:33 +0900 Subject: [PATCH 2/2] Address a review comment --- cpp/src/arrow/compute/kernels/vector_array_sort.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/src/arrow/compute/kernels/vector_array_sort.cc b/cpp/src/arrow/compute/kernels/vector_array_sort.cc index 4f91fb8c6b6..0c27808dd10 100644 --- a/cpp/src/arrow/compute/kernels/vector_array_sort.cc +++ b/cpp/src/arrow/compute/kernels/vector_array_sort.cc @@ -183,8 +183,8 @@ class ArrayCompareSorter { const ArraySortOptions& options, ExecContext* ctx) { const auto& dict_array = checked_cast(array); - auto dict_values = dict_array.dictionary(); - auto dict_indices = dict_array.indices(); + const auto& dict_values = dict_array.dictionary(); + const auto& dict_indices = dict_array.indices(); // Algorithm: // 1) Use the Rank function to get an exactly-equivalent-order array