Commit d65eb94
authored
MINOR: [C++] Remove TODO asking why null count set unknown (#48823)
### Rationale for this change
Removed a TODO from `replace_with_mask` implementation that asking why the replacements null count wasn't sufficient for a slice operation. When slicing an array, the null count from the original full array doesn't apply to the slice.
The null count must be marked as `kUnknownNullCount` and computed lazily when needed.
### What changes are included in this PR?
Replaced the TODO with some comments clarifying:
- Why manual slicing is used (avoids extra allocation from `ArrayData::Slice()`)
- Why `kUnknownNullCount` is necessary (original null count doesn't apply to slice)
### Are these changes tested?
No, I did not test.
### Are there any user-facing changes?
No.
Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>1 parent b14c6e0 commit d65eb94
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
255 | | - | |
| 255 | + | |
| 256 | + | |
256 | 257 | | |
257 | 258 | | |
258 | 259 | | |
259 | | - | |
260 | | - | |
| 260 | + | |
| 261 | + | |
261 | 262 | | |
262 | 263 | | |
263 | 264 | | |
| |||
0 commit comments