add PYARROW_TEST_ANNOTATIONS to AMD64 Windows 2022 Python 3.13

change bat
lint
add a popd and nicer logging for windows
ReplaceElipsis -> DocstringInserter
simplify
remove sphinx

Author: rok

.github/workflows/python.yml

@@ -303,5 +303,7 @@ jobs:
           call "ci\scripts\python_test.bat" %cd%
       - name: Test annotations
         shell: cmd
+        env:
+          PYARROW_TEST_ANNOTATIONS: "ON"
         run: |
           call "ci\scripts\python_test_type_annotations.bat" %cd%\python

ci/scripts/python_test_type_annotations.bat

@@ -23,15 +23,18 @@ if "%PYARROW_TEST_ANNOTATIONS%"=="ON" (
     echo Annotation testing on Windows ...
 
     @REM Install library stubs. Note some libraries contain their own type hints so they need to be installed.
-    %PYTHON_CMD% -m pip install fsspec pandas-stubs scipy-stubs sphinx types-cffi types-psutil types-requests types-python-dateutil || exit /B 1
+    %PYTHON_CMD% -m pip install fsspec pandas-stubs scipy-stubs types-cffi types-psutil types-requests types-python-dateutil || exit /B 1
 
     @REM Install type checkers
     %PYTHON_CMD% -m pip install mypy pyright ty || exit /B 1
 
     @REM Run type checkers
     pushd %PYARROW_DIR%
 
-    mypy
-    pyright
-    ty check
+    mypy || exit /B 1
+    pyright || exit /B 1
+    ty check || exit /B 1
+    popd
+) else (
+    echo Annotation testing skipped on Windows ...
 )

ci/scripts/python_test_type_annotations.sh

@@ -36,6 +36,7 @@ if [ "${PYARROW_TEST_ANNOTATIONS}" == "ON" ]; then
   mypy
   pyright
   ty check;
+  popd
 else
   echo "Skipping type annotation tests";
 fi

dev/update_stub_docstrings.py

@@ -31,12 +31,12 @@
 from pathlib import Path
 from textwrap import indent
 
-# Add current directory to path to find locally built pyarrow
-sys.path.insert(0, ".")
-
 import libcst
 from libcst import matchers as m
 
+# Add current directory to path to find locally built pyarrow
+sys.path.insert(0, ".")
+
 
 def _resolve_object(module, path):
     """
@@ -66,13 +66,8 @@ def _resolve_object(module, path):
         try:
             obj = getattr(obj, part)
         except AttributeError:
-            # Fallback: try __dict__ access for special methods like __init__
+            # Fallback: try vars() for special methods like __init__
             # that may not be directly accessible via getattr
-            if hasattr(parent, "__dict__"):
-                obj = parent.__dict__.get(part)
-                if obj is not None:
-                    continue
-            # Try vars() as another fallback
             try:
                 obj = vars(parent).get(part)
                 if obj is not None:
@@ -137,7 +132,7 @@ def _get_docstring(name, module, indentation):
     return docstring
 
 
-class ReplaceEllipsis(libcst.CSTTransformer):
+class DocstringInserter(libcst.CSTTransformer):
     def __init__(self, module, namespace):
         self.module = module
         self.base_namespace = namespace
@@ -277,7 +272,7 @@ def add_docs_to_stub_files(pyarrow_folder):
         elif module == "__init__":
             module = ""
 
-        modified_tree = tree.visit(ReplaceEllipsis(pyarrow_module, module))
+        modified_tree = tree.visit(DocstringInserter(pyarrow_module, module))
         with open(stub_file, "w") as f:
             f.write(modified_tree.code)
         print("\n")