[AMORO-4242][Helm] Add Gateway API HTTPRoute support to the Amoro chart#4243
Open
somaz94 wants to merge 1 commit into
Open
[AMORO-4242][Helm] Add Gateway API HTTPRoute support to the Amoro chart#4243somaz94 wants to merge 1 commit into
somaz94 wants to merge 1 commit into
Conversation
Signed-off-by: somaz <genius5711@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds optional Gateway API
HTTPRoutesupport to thecharts/amoroHelm chart, as an alternative to the existingIngressfor clusters that have standardized on the Gateway API.The change is purely additive — the existing
Ingresstemplate and its tests are untouched, andhttpRoute.enableddefaults tofalse, so existing installations are unaffected.values.yaml: newhttpRouteblock (enabled,parentRefs,hostname,path,pathType,annotations,extraHosts,extraRules), mirroring the shape and## @paramdocumentation of the existingingressblock.templates/amoro-httproute.yaml: new template gated onhttpRoute.enabled, rendering agateway.networking.k8s.io/v1HTTPRoutethat backends to the existing<fullname>-restService (port1630) — the same Service theIngresstargets. It reuses the chart'scommon.names.*,common.labels.standard, andcommon.tplvalues.*helpers.tests/amoro-httproute_test.yaml: 12 helm-unittest cases mirroringamoro-ingress_test.yaml.Why are the changes needed?
Gateway API is the successor to Ingress and is the recommended north-south routing API on many clusters (Istio, Envoy Gateway, Cilium, Kong, …). Users running a Gateway-API-based ingress data plane currently have to hand-write an
HTTPRouteoutside the chart to expose the Amoro dashboard. This lets them do it declaratively through the chart, the same wayingress.enabledworks today.Brief change log
httpRouteparameter block tocharts/amoro/values.yamlcharts/amoro/templates/amoro-httproute.yamlcharts/amoro/tests/amoro-httproute_test.yaml(12 helm-unittest cases)How was this patch tested?
helm unittest charts/amoro— 8 suites / 87 tests pass (12 new HTTPRoute cases + existing suites, no regression).helm lint charts/amoro --set httpRoute.enabled=true— passes.helm templaterendered for three scenarios — disabled (0 documents), enabled withparentRefs+ annotations, and enabled withextraHosts+ custom path/pathType +extraRules— all render as expected and backend to<release>-amoro-rest:1630.Parameters are documented inline via
## @paramcomments invalues.yaml, consistent with how the existingingressparameters are documented (the chartREADME.mddoes not carry a per-parameter table).fix #4242