Skip to content

This looks behavior-preserving rather than a parser fix. The original condition already only keeps minItems when the value is 0 or 1; min_items == 1 is false for None, so the added tests would pass on the current code too. #1601

@abobakr200023-ship-it

Description

@abobakr200023-ship-it

This looks behavior-preserving rather than a parser fix. The original condition already only keeps minItems when the value is 0 or 1; min_items == 1 is false for None, so the added tests would pass on the current code too.

If the goal is readability, it may be clearer to frame this as a small cleanup. If there is an actual failing schema case, the regression test should cover a value that fails before this change.

Originally posted by @kiwigitops in #1600 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions