fix(cli): show multi-file apply_patch diffs#17080
Open
german-swan wants to merge 2 commits intoanomalyco:devfrom
Open
fix(cli): show multi-file apply_patch diffs#17080german-swan wants to merge 2 commits intoanomalyco:devfrom
german-swan wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: PR #15893: fix: re-read files after formatting in apply_patch This PR is related to All other search results returned PR #17080 itself or unrelated PRs. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17076
Type of change
What does this PR do?
apply_patchalready returns per-file diff metadata, but the CLI permission view still treated patch approvals like a single-file edit and only showed one diff block. This updates the TUI approval renderer to usemetadata.fileswhen present, keep each file path as a header, and place the whole patch set inside one shared scroll area so multi-file reviews are easier to navigate.It also adds explicit
apply_patchrendering inrunmode so non-interactive CLI output prints one diff block per changed file instead of falling back to generic tool output.How did you verify your code works?
bun run typecheckinpackages/opencodeapply_patchlocally in TUI and confirmed all file diffs render in one scrollable view with per-file headersScreenshots / recordings
Checklist