fix include detail in start mining rights toast

Author: baderdean

frontend/src/tests/unit/mining-toast.test.ts

@@ -0,0 +1,50 @@
+import { describe, expect, it } from 'vitest';
+
+import { createStartMiningToastPayload } from '@/utils/extras';
+
+describe('createStartMiningToastPayload', () => {
+  const translations: Record<string, string> = {
+    'mining.contacts_got_rights_title': 'Vos contacts ont des droits',
+    'mining.contacts_got_rights_detail':
+      "Vous avez besoin du consentement ou d'un intérêt légitime pour les contacter.",
+    'mining.learn_more_about_rights':
+      'En savoir plus sur les droits de vos contacts',
+  };
+
+  const t = (key: string) => translations[key] ?? key;
+
+  it('creates a has-links toast payload with message and link', () => {
+    const payload = createStartMiningToastPayload({
+      t,
+      dataPrivacyUrl: 'https://leadminer.io/privacy',
+    });
+
+    expect(payload).toEqual({
+      severity: 'info',
+      group: 'has-links',
+      summary: 'Vos contacts ont des droits',
+      detail: {
+        message:
+          "Vous avez besoin du consentement ou d'un intérêt légitime pour les contacter.",
+        link: {
+          text: 'En savoir plus sur les droits de vos contacts',
+          url: 'https://leadminer.io/privacy',
+        },
+      },
+      life: 8000,
+    });
+  });
+
+  it('always keeps a detail message even when privacy url is missing', () => {
+    const payload = createStartMiningToastPayload({
+      t,
+      dataPrivacyUrl: undefined,
+    });
+
+    expect(payload.group).toBe('has-links');
+    expect(payload.detail).toEqual({
+      message:
+        "Vous avez besoin du consentement ou d'un intérêt légitime pour les contacter.",
+    });
+  });
+});

frontend/src/utils/extras.ts

@@ -8,21 +8,51 @@ type ToastLike = {
   add: (payload: {
     severity: string;
     summary: string;
-    detail: string;
+    detail: string | { message: string; link?: { text: string; url: string } };
+    group?: string;
     life: number;
   }) => void;
 };
 
+type StartMiningToastInput = {
+  t: (key: string) => string;
+  dataPrivacyUrl?: string;
+};
+
+export function createStartMiningToastPayload({
+  t,
+  dataPrivacyUrl,
+}: StartMiningToastInput) {
+  return {
+    severity: 'info' as const,
+    group: 'has-links' as const,
+    summary: t('mining.contacts_got_rights_title'),
+    detail: {
+      message: t('mining.contacts_got_rights_detail'),
+      ...(dataPrivacyUrl
+        ? {
+            link: {
+              text: t('mining.learn_more_about_rights'),
+              url: dataPrivacyUrl,
+            },
+          }
+        : {}),
+    },
+    life: 8000,
+  };
+}
+
 export function startMiningNotification(
   toast: ToastLike,
   t: (key: string) => string,
+  dataPrivacyUrl?: string,
 ) {
-  toast.add({
-    severity: 'info',
-    summary: t('mining.contacts_got_rights_title'),
-    detail: t('mining.contacts_got_rights_detail'),
-    life: 8000,
-  });
+  toast.add(
+    createStartMiningToastPayload({
+      t,
+      dataPrivacyUrl,
+    }),
+  );
 }
 
 export function getLocationUrl(location: NormalizedLocation) {