Merge pull request #1057 from yassinesos/fix/i18n-translation-issues

fix(native-federation): fix i18n translation for lazy chunks and Windows #1055

Author: Aukevanoost

libs/native-federation/src/utils/i18n.ts

@@ -78,22 +78,18 @@ export async function translateFederationArtefacts(
 
   const translationOutPath = path.join(outputPath, 'browser', '{{LOCALE}}');
 
-  const federationFiles = [
-    ...federationResult.shared.map((s) => s.outFileName),
-    ...federationResult.exposes.map((e) => e.outFileName),
-  ];
-
-  // Here, we use a glob with an exhaustive list i/o `"*.js"`
-  // to improve performance
-  const sourcePattern = '{' + federationFiles.join(',') + '}';
+  // Use *.js to translate ALL JS files, including lazy-loaded chunks
+  // that may contain $localize markers from exposed modules
+  const sourcePattern = '*.js';
 
   const sourceLocalePath = path.join(outputPath, 'browser', sourceLocale);
 
   const localizeTranslate = path.resolve(
     'node_modules/.bin/localize-translate',
   );
 
-  const cmd = `${localizeTranslate} -r ${sourceLocalePath} -s "${sourcePattern}" -t ${translationFiles} -o ${translationOutPath} --target-locales ${targetLocales} -l ${sourceLocale}`;
+  // Quote paths to handle spaces (Windows compatibility)
+  const cmd = `"${localizeTranslate}" -r "${sourceLocalePath}" -s "${sourcePattern}" -t ${translationFiles} -o "${translationOutPath}" --target-locales ${targetLocales} -l ${sourceLocale}`;
 
   ensureDistFolders(locales, outputPath);
   copyRemoteEntry(locales, outputPath, sourceLocalePath);