Add Format.selectionPriority and parse from HLS SCORE#3236
Open
AndyWangLYN wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Format.selectionPriorityand populates it from the HLSSCOREattribute onEXT-X-STREAM-INF/EXT-X-I-FRAME-STREAM-INF.Extraction-only — no selection behavior changes. Apps that want ABR to honor the field can install a
Comparator<Format>viaAdaptiveTrackSelection.Factory#setTrackFormatComparator(#3068).DASH
@selectionPriorityparsing follows in a separate PR.Spec
draft-pantos-hls-rfc8216bis-22 §4.4.6.2
(SCORE on EXT-X-STREAM-INF), §4.4.6.3 (inherits to EXT-X-I-FRAME-STREAM-INF), §6.3.1 (client behavior).
Notes for reviewers
setSelectionPrioritydoesn't validate inputs — matchesFormatBuilder convention (grep -n "checkArgument" Format.javareturns zero hits).Test plan
./gradlew :lib-common:test./gradlew :lib-exoplayer-hls:connectedAndroidTestgit diff -U0 main... | google-java-format-diff.py -p1 -i