Commit 8bafa18
Align Matroska and MP4 color info extraction
Previously, `MatroskaExtractor` relied exclusively on container-level EBML tags for building `ColorInfo` and defaulted bit depths to `Format.NO_VALUE`. This resulted in missing or inaccurate metadata compared to MP4 extraction, which properly utilizes codec bitstream information.
This change updates `MatroskaExtractor` to replicate the color info extraction logic from `Mp4Extractor` (`BoxParser`):
- Color information (color space, transfer, range) and bit depths are now extracted from the codec bitstream (`AvcConfig`, `HevcConfig`) and safely take precedence over container-level metadata.
- Luma and chroma bit depths are now tracked and overridden independently.
- The default bit depth for video tracks is now set to 8, and `ColorInfo` is unconditionally built for all video tracks.
Extractor test dump files have been updated to reflect the newly populated `ColorInfo` fields.
PiperOrigin-RevId: 8796913501 parent b8a4643 commit 8bafa18
110 files changed
Lines changed: 399 additions & 30 deletions
File tree
- libraries
- extractor/src/main/java/androidx/media3/extractor/mkv
- test_data/src/test/assets
- extractordumps
- mkv_subtitle_transcoding
- mkv
- muxerdumps/webm
- transformerdumps/mkv/sample_with_srt.mkv
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
Lines changed: 63 additions & 26 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
830 | 830 | | |
831 | 831 | | |
832 | 832 | | |
833 | | - | |
834 | | - | |
835 | | - | |
836 | 833 | | |
837 | 834 | | |
838 | 835 | | |
| |||
1248 | 1245 | | |
1249 | 1246 | | |
1250 | 1247 | | |
1251 | | - | |
1252 | 1248 | | |
1253 | 1249 | | |
1254 | | - | |
| 1250 | + | |
1255 | 1251 | | |
1256 | 1252 | | |
1257 | 1253 | | |
1258 | 1254 | | |
1259 | 1255 | | |
1260 | 1256 | | |
1261 | | - | |
| 1257 | + | |
1262 | 1258 | | |
1263 | 1259 | | |
1264 | 1260 | | |
1265 | 1261 | | |
1266 | | - | |
1267 | 1262 | | |
1268 | 1263 | | |
1269 | 1264 | | |
1270 | 1265 | | |
1271 | 1266 | | |
1272 | 1267 | | |
1273 | | - | |
| 1268 | + | |
1274 | 1269 | | |
1275 | 1270 | | |
1276 | | - | |
| 1271 | + | |
1277 | 1272 | | |
1278 | 1273 | | |
1279 | 1274 | | |
| |||
2253 | 2248 | | |
2254 | 2249 | | |
2255 | 2250 | | |
2256 | | - | |
2257 | | - | |
2258 | | - | |
2259 | | - | |
| 2251 | + | |
| 2252 | + | |
| 2253 | + | |
2260 | 2254 | | |
2261 | 2255 | | |
2262 | 2256 | | |
| |||
2300 | 2294 | | |
2301 | 2295 | | |
2302 | 2296 | | |
| 2297 | + | |
| 2298 | + | |
| 2299 | + | |
| 2300 | + | |
| 2301 | + | |
2303 | 2302 | | |
2304 | 2303 | | |
2305 | 2304 | | |
| |||
2328 | 2327 | | |
2329 | 2328 | | |
2330 | 2329 | | |
| 2330 | + | |
| 2331 | + | |
| 2332 | + | |
| 2333 | + | |
| 2334 | + | |
2331 | 2335 | | |
2332 | 2336 | | |
2333 | 2337 | | |
2334 | 2338 | | |
2335 | 2339 | | |
2336 | 2340 | | |
2337 | 2341 | | |
| 2342 | + | |
| 2343 | + | |
| 2344 | + | |
| 2345 | + | |
| 2346 | + | |
2338 | 2347 | | |
2339 | 2348 | | |
2340 | 2349 | | |
| |||
2524 | 2533 | | |
2525 | 2534 | | |
2526 | 2535 | | |
2527 | | - | |
2528 | | - | |
2529 | | - | |
2530 | | - | |
2531 | | - | |
2532 | | - | |
2533 | | - | |
2534 | | - | |
2535 | | - | |
2536 | | - | |
2537 | | - | |
2538 | | - | |
2539 | | - | |
| 2536 | + | |
| 2537 | + | |
| 2538 | + | |
| 2539 | + | |
| 2540 | + | |
| 2541 | + | |
| 2542 | + | |
| 2543 | + | |
| 2544 | + | |
| 2545 | + | |
| 2546 | + | |
| 2547 | + | |
| 2548 | + | |
| 2549 | + | |
| 2550 | + | |
| 2551 | + | |
| 2552 | + | |
| 2553 | + | |
| 2554 | + | |
| 2555 | + | |
| 2556 | + | |
| 2557 | + | |
| 2558 | + | |
| 2559 | + | |
| 2560 | + | |
| 2561 | + | |
| 2562 | + | |
| 2563 | + | |
| 2564 | + | |
| 2565 | + | |
| 2566 | + | |
| 2567 | + | |
| 2568 | + | |
| 2569 | + | |
| 2570 | + | |
| 2571 | + | |
| 2572 | + | |
| 2573 | + | |
| 2574 | + | |
| 2575 | + | |
| 2576 | + | |
2540 | 2577 | | |
2541 | 2578 | | |
2542 | 2579 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
| |||
0 commit comments